From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Date: Thu, 27 Jun 2024 10:37:24 +0300 Message-ID: <864j9e7s5n.fsf@gnu.org> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13101"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acorallo@gnu.org, 71499@debbugs.gnu.org, stefankangas@gmail.com To: bkhl@elektrubadur.se Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 27 09:38:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMjhs-0003AJ-Gs for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jun 2024 09:38:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMjhg-0005rb-Qf; Thu, 27 Jun 2024 03:38:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMjhf-0005rE-58 for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 03:37:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMjhe-00026p-T2 for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 03:37:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMjhh-00062G-Jn for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 03:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 07:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71499 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71499-submit@debbugs.gnu.org id=B71499.171947385823163 (code B ref 71499); Thu, 27 Jun 2024 07:38:01 +0000 Original-Received: (at 71499) by debbugs.gnu.org; 27 Jun 2024 07:37:38 +0000 Original-Received: from localhost ([127.0.0.1]:40895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMjhK-00061X-2f for submit@debbugs.gnu.org; Thu, 27 Jun 2024 03:37:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMjhI-00061F-0q for 71499@debbugs.gnu.org; Thu, 27 Jun 2024 03:37:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMjh8-0001wS-QV; Thu, 27 Jun 2024 03:37:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=oSlXo2EOcW4nBl1ThFX41MuEtGMgNfQtabNdoe+jZvU=; b=Mv4002mBzVrtfnwRVXMn pP2cCRYCbjohhsWBGVL4+vvZzgyOsYCZ/eBVow/YxvWhFj9qHKQlWVHyJlmPXerG8rUg8nRwWbl3N ZBbCL9Go7yuxLkoyhJS1gaYdiWG44rNt4WoyN3frH7e+MPkI9UjSkojnw32VL8QB7dAGHYX7rKyNd 4FS3Z0zbiGtDVMf+gxiqIWuXSuCImelqet6qlACMpUkdzoGD4Pj2qE36gg0/c4leAPKOHIsEb+9/6 /HvaXM3XAC7KmyXIUbOscHjDVNhMempJdn/luHH7HLx4UABRXxnl4TjMSzbD5quMqgtt+8w/LGCUo iuJT2xSQtsC4bg==; In-Reply-To: <86jzitz1l0.fsf@gnu.org> (message from Eli Zaretskii on Thu, 13 Jun 2024 11:30:51 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287992 Archived-At: > Cc: 71499@debbugs.gnu.org, stefankangas@gmail.com, bkhl@elektrubadur.se > Date: Thu, 13 Jun 2024 11:30:51 +0300 > From: Eli Zaretskii > > Meanwhile, Björn, I have a few comments to the patch: > > . it needs a NEWS entry announcing the new feature > . is there any reason your code to handle the missing newline is not > identical to what the implementation of require-final-newline > does? Ping! Björn, can you please post an updated patch with the above nits taken care of? We can install this now on the master branch.