From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too Date: Tue, 02 Jul 2024 14:12:57 +0300 Message-ID: <864j98dp3a.fsf@gnu.org> References: <171823002031.28307.18221225159709452537@vcs2.savannah.gnu.org> <20240612220700.A0F4DC1FB4C@vcs2.savannah.gnu.org> <86h6dwf40q.fsf@mail.linkov.net> <86frtffpdb.fsf@mail.linkov.net> <867ce6pwrq.fsf@mail.linkov.net> <86jzi5bnnz.fsf@mail.linkov.net> <8634otqdn2.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19077"; mail-complaints-to="usenet@ciao.gmane.io" Cc: me@eshelyaron.com, emacs-devel@gnu.org, dmitry@gutov.dev To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 02 13:14:26 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sObSr-0004hl-DB for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Jul 2024 13:14:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sObRr-00005x-18; Tue, 02 Jul 2024 07:13:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sObRh-00005H-Sl for emacs-devel@gnu.org; Tue, 02 Jul 2024 07:13:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sObRf-0007d0-71; Tue, 02 Jul 2024 07:13:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=KFUC0jIpqf0iwX+mmeubmln+zllR+TN1IFlG62Y5ovI=; b=NZfmz8ZL4zeauEU5dPfV kyLfeNTnPj3/aKAEDkGL40Cx0bkIEraeXgHF+XWL1XgIU84QLvcmjMyPspq6omkaro46PR/YTyKDK itZX9D4MSJmW2Or4lqAHBV9VP3Run79i6NIVMG3gUska1Ih4v+fDa2fbLzqgrPfrVAPVYS6XRXzkU GMsYkx/fC/ZOR8QBEAJYDZ9vG8euCNWlHSFKwyaz26GZx9t9aHnLBch3LpK9GZMX9+4OXYIBhiaxf qnlonWKYJ9P4q/A2AQYxYtHebDypRzN6GnwPW0LiDfr8M06YxqnGXTOgUC5TMdcaAa+NwKAag/Puw s9+IG4g114sQgw==; In-Reply-To: <8634otqdn2.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 01 Jul 2024 19:29:37 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321123 Archived-At: > From: Juri Linkov > Cc: emacs-devel@gnu.org, Dmitry Gutov > Date: Mon, 01 Jul 2024 19:29:37 +0300 > > >>>> 1. M-x icomplete-mode RET > >>>> 2. M-x rgrep RET foo RET b > >>>> > >>>> Error in post-command-hook (icomplete-post-command-hook): > >>>> (wrong-type-argument number-or-marker-p nil) > >>> > >>> Ouch. AFAICT the problem is in grep.el, and it's not specific to > >>> icomplete-mode, e.g. I can reproduce it with: > >>> > >>> M-: (grep-read-files "foo") RET b ? > >> > >> Also typing 'el TAB' after RET gives: > >> > >> Debugger entered--Lisp error: (error "Internal error: all doesn’t match \\`el") > >> signal(error ("Internal error: all doesn’t match \\`el")) > >> error("Internal error: %s doesn't match %s" "all" "\\`el") > >> completion-pcm--merge-completions(("all" "el" "ch" "c" "cc" "cchh" "hh" "h" "l" "am" "m" "tex" "texi" "asm") ("el")) > >> completion-pcm--merge-try(("el") ("all" "el" "ch" "c" "cc" "cchh" "hh" "h" "l" "am" "m" "tex" "texi" "asm") "" "") > >> > >>> Does the diff below help? > >> > >> Thanks, after short testing I see it doesn't lose the ability to complete > >> in both cases: a list of abbreviations and file names, while fixing > >> the problem above, so it looks like the right thing to do. > > > > Great. > > > >>> (Note that this change has the downside that file name quoting/unquoting > >>> is no longer applied. Handling that with completion-table-merge might > >>> be a bit more tricky.) > >> > >> Not sure how serious this limitation is. > > > > Yes, it's very minor, I think. > > > > This issue is present already in Emacs 29 with partial-completion at the > > front of completion-styles, but in Emacs 30 it affects the default setup. > > Should we fix this on master or on the release branch? > > I don't know what Eli will decide, but this bug exists in the release branch. Please fix on the emacs-30 release branch, and thanks.