From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: me@eshelyaron.com, emacs-devel@gnu.org, dmitry@gutov.dev
Subject: Re: master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too
Date: Tue, 02 Jul 2024 14:12:57 +0300 [thread overview]
Message-ID: <864j98dp3a.fsf@gnu.org> (raw)
In-Reply-To: <8634otqdn2.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 01 Jul 2024 19:29:37 +0300)
> From: Juri Linkov <juri@linkov.net>
> Cc: emacs-devel@gnu.org, Dmitry Gutov <dmitry@gutov.dev>
> Date: Mon, 01 Jul 2024 19:29:37 +0300
>
> >>>> 1. M-x icomplete-mode RET
> >>>> 2. M-x rgrep RET foo RET b
> >>>>
> >>>> Error in post-command-hook (icomplete-post-command-hook):
> >>>> (wrong-type-argument number-or-marker-p nil)
> >>>
> >>> Ouch. AFAICT the problem is in grep.el, and it's not specific to
> >>> icomplete-mode, e.g. I can reproduce it with:
> >>>
> >>> M-: (grep-read-files "foo") RET b ?
> >>
> >> Also typing 'el TAB' after RET gives:
> >>
> >> Debugger entered--Lisp error: (error "Internal error: all doesn’t match \\`el")
> >> signal(error ("Internal error: all doesn’t match \\`el"))
> >> error("Internal error: %s doesn't match %s" "all" "\\`el")
> >> completion-pcm--merge-completions(("all" "el" "ch" "c" "cc" "cchh" "hh" "h" "l" "am" "m" "tex" "texi" "asm") ("el"))
> >> completion-pcm--merge-try(("el") ("all" "el" "ch" "c" "cc" "cchh" "hh" "h" "l" "am" "m" "tex" "texi" "asm") "" "")
> >>
> >>> Does the diff below help?
> >>
> >> Thanks, after short testing I see it doesn't lose the ability to complete
> >> in both cases: a list of abbreviations and file names, while fixing
> >> the problem above, so it looks like the right thing to do.
> >
> > Great.
> >
> >>> (Note that this change has the downside that file name quoting/unquoting
> >>> is no longer applied. Handling that with completion-table-merge might
> >>> be a bit more tricky.)
> >>
> >> Not sure how serious this limitation is.
> >
> > Yes, it's very minor, I think.
> >
> > This issue is present already in Emacs 29 with partial-completion at the
> > front of completion-styles, but in Emacs 30 it affects the default setup.
> > Should we fix this on master or on the release branch?
>
> I don't know what Eli will decide, but this bug exists in the release branch.
Please fix on the emacs-30 release branch, and thanks.
next prev parent reply other threads:[~2024-07-02 11:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171823002031.28307.18221225159709452537@vcs2.savannah.gnu.org>
[not found] ` <20240612220700.A0F4DC1FB4C@vcs2.savannah.gnu.org>
2024-06-13 8:20 ` master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too Eshel Yaron
2024-06-13 14:11 ` Dmitry Gutov
2024-06-13 14:51 ` Eshel Yaron
2024-06-14 6:10 ` Juri Linkov
2024-06-14 7:35 ` Eshel Yaron
2024-06-14 16:41 ` Juri Linkov
2024-06-14 18:04 ` Eshel Yaron
2024-06-14 22:44 ` Dmitry Gutov
2024-06-30 16:29 ` Juri Linkov
2024-06-30 18:14 ` Eshel Yaron
2024-07-01 6:57 ` Juri Linkov
2024-07-01 8:58 ` Eshel Yaron
2024-07-01 16:29 ` Juri Linkov
2024-07-02 11:12 ` Eli Zaretskii [this message]
2024-07-02 12:17 ` Eshel Yaron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864j98dp3a.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dmitry@gutov.dev \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.