From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Date: Thu, 04 Jul 2024 21:07:36 +0300 Message-ID: <864j9581zr.fsf@gnu.org> References: <86ikxltzhx.fsf@mail.linkov.net> <861q49a8vt.fsf@gnu.org> <86y16h8olf.fsf@gnu.org> <878qyh79ov.fsf@gmx.net> <86zfqxqi6e.fsf@mail.linkov.net> <87v81l5aal.fsf@gmx.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30175"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jpw@gnu.org, juri@linkov.net, me@eshelyaron.com, basil@contovou.net, 71927@debbugs.gnu.org, kickingvegas@gmail.com To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 20:09:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPQtM-0007Zg-Od for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 20:09:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPQtB-0008Gz-0x; Thu, 04 Jul 2024 14:09:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPQt9-0008Gm-Ed for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:08:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPQt9-0003MG-5r for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:08:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPQtB-0000wE-Kg for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 18:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71927 X-GNU-PR-Package: emacs Original-Received: via spool by 71927-submit@debbugs.gnu.org id=B71927.17201164823524 (code B ref 71927); Thu, 04 Jul 2024 18:09:01 +0000 Original-Received: (at 71927) by debbugs.gnu.org; 4 Jul 2024 18:08:02 +0000 Original-Received: from localhost ([127.0.0.1]:42929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPQsE-0000uZ-5i for submit@debbugs.gnu.org; Thu, 04 Jul 2024 14:08:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPQsC-0000uI-Ep for 71927@debbugs.gnu.org; Thu, 04 Jul 2024 14:08:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPQs4-0003FU-Fa; Thu, 04 Jul 2024 14:07:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=g4CrNM2ZaJSLkDeXHYPYJayYRrWv8GyIz5TjlU5FcjU=; b=Fa3ihtmQn91z 2LibfzOfCbSrR2xz9YmR+4JwegW9eAaQJfas4han5k+E8HNQXABXVvMewRjy4YsJXG3r5wWS8+KvU hWqabQfLZdsSB6KQQqN58qMG+yznH8YFtLcD9QtrWGaEpvpVPcZzozOZ1G1zWmU9uCmfPMaV/atbo u/ELBfgSnWVG8uZvtBw3Fc54hI5K/IoDC+OtBT0zhgk0Y2aKHpBXi6tO4FinDmQEqrHDQn89Dk2ei 2F5sCkUGouW+Q7CNIWUFHICgisjBvi7YUOdWtlRqj5nbpeCySfteWKKa0FPJOz3fpSIFg62itLH5m xcl2feRZZpomMXNW4JkYrA==; In-Reply-To: <87v81l5aal.fsf@gmx.net> (message from Stephen Berman on Thu, 04 Jul 2024 19:36:34 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288388 Archived-At: > From: Stephen Berman > Cc: Eli Zaretskii , Eshel Yaron , > kickingvegas@gmail.com, 71927@debbugs.gnu.org, basil@contovou.net, > jpw@gnu.org > Date: Thu, 04 Jul 2024 19:36:34 +0200 > > On Thu, 04 Jul 2024 19:04:42 +0300 Juri Linkov wrote: > > >>>> FWIW, AFAICT everything is working correctly, it's just that the > >>>> "Operation finished" message hides the prompt. ibuffer-do-isearch > >>>> should tell define-ibuffer-op not to display that message, somehow. > >>> > >>> I don't see how this could be considered "correct": the "Operation > >>> finished" message is supposed to be shown only after the Isearch is > >>> finished in all the marked buffer, not before. It looks like we need > >>> a function that will not return until all the buffers where searched, > >>> because that's what define-ibuffer-op expects. Don't you agree? > > > > It intentionally uses 'no-recursive-edit' set to t, so ibuffer-do-isearch > > correctly exits immediately while leaving isearch-mode enabled. > > > >> The attached patch appears to DTRT, but I only tested it briefly. > >> ... > >> (define-ibuffer-op ibuffer-do-isearch () > >> "Perform a `isearch-forward' in marked buffers." > >> (:interactive () > >> - :opstring "searched in" > >> + :no-opstring t > > > > Thanks for the patch. I confirm this is the right thing to do. > > Maybe instead of :no-opstring would be better to use some special value > > like :opstring 'no? But I'm not sure if this is better than :no-opstring. > > Suppressing the message when :opstring has the value 'no is fine with > me. If Eli is willing to accept this approach, I can go ahead and > commit it (to master, presumably, since this is a longstanding issue). I already said this didn't sound the right solution here, and I explained why. I'd be interested in hearing counter-arguments, if there are any.