bug#72034: 29.3; python-ts-mode navigation fails

bug#72034: 29.3; python-ts-mode navigation fails

[Tim Loderhose]

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

python-nav-forward-defun doesn't work properly in python-ts-mode, for
example with this file:
https://raw.githubusercontent.com/timlod/onset-fingerprinting/6c8f9bd3b82398c9af3519036e0d5a550ad3bae7/onset_fingerprinting/data.py

Specifically, at some point it will stop navigating, even though there
are still function definitions to traverse (other times I saw it skipped
some definitions before stopping altogether). I noticed that this
usually happens after some point in the buffer, but I haven't been able
to nail it down exactly. My hunch is that it could be related to
decorators (e.g. @classmethod) or type hints, or both.

It does work properly using just python-mode. This is tested using
`emacs -q`, so this bug persists just on a clean Emacs 29.3.

I checked previous reports and believe this is probably related to
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60856, which isn't fixed yet.

In GNU Emacs 29.3 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.33,
cairo version 1.16.0) of 2024-06-08 built on pop-os
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Pop!_OS 22.04 LTS

Configured using:
'configure --with-native-compilation --with-json --without-mailutils
--without-pop'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
value of $LANG: en_GB.UTF-8
locale-coding-system: utf-8

[-- Attachment #2: Type: text/html, Size: 3178 bytes --]

bug#72034: 29.3; python-ts-mode navigation fails

[Eli Zaretskii]

> Date: Wed, 10 Jul 2024 09:45:01 +0000
> From: Tim Loderhose <tim@loderhose.com>
> 
> python-nav-forward-defun doesn't work properly in python-ts-mode, for
> example with this file:
> https://raw.githubusercontent.com/timlod/onset-fingerprinting/6c8f9bd3b82398c9af3519036e0d5a550ad3bae7/onset_fingerprinting/data.py
> 
> 
> Specifically, at some point it will stop navigating, even though there
> are still function definitions to traverse (other times I saw it skipped
> some definitions before stopping altogether). I noticed that this
> usually happens after some point in the buffer, but I haven't been able
> to nail it down exactly. My hunch is that it could be related to
> decorators (e.g. @classmethod) or type hints, or both.

I can reproduce this in Emacs 29, but not on the current emacs-30
release branch, which will eventually become Emacs 30.  So I guess we
already fixed that meanwhile.  Can you try building the development
code of Emacs and see if the problem goes away?

Thanks.

bug#72034: 29.3; python-ts-mode navigation fails

[Tim Loderhose]

I just built the latest emacs-30, and indeed the problem appears to be fixed there!

On Wednesday, July 10th, 2024 at 2:13 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Wed, 10 Jul 2024 09:45:01 +0000
> > From:
> > 
> > Tim
> > 
> > Loderhose tim@loderhose.com
> > 
> > python-nav-forward-defun doesn't work properly in python-ts-mode, for
> > example with this file:
> > https://raw.githubusercontent.com/timlod/onset-fingerprinting/6c8f9bd3b82398c9af3519036e0d5a550ad3bae7/onset_fingerprinting/data.py
> > 
> > Specifically, at some point it will stop navigating, even though there
> > are still function definitions to traverse (other times I saw it skipped
> > some definitions before stopping altogether). I noticed that this
> > usually happens after some point in the buffer, but I haven't been able
> > to nail it down exactly. My hunch is that it could be related to
> > decorators (e.g. @classmethod) or type hints, or both.
> 
> 
> I can reproduce this in Emacs 29, but not on the current emacs-30
> release branch, which will eventually become Emacs 30. So I guess we
> already fixed that meanwhile. Can you try building the development
> code of Emacs and see if the problem goes away?
> 
> Thanks.

bug#72034: 29.3; python-ts-mode navigation fails

[Eli Zaretskii]

> Date: Mon, 15 Jul 2024 09:54:05 +0000
> From: Tim Loderhose <tim@loderhose.com>
> Cc: 72034@debbugs.gnu.org
> 
> I just built the latest emacs-30, and indeed the problem appears to be fixed there!

Thanks for testing, I'm therefore closing this bug.