From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70007: [PATCH] native JSON encoder Date: Sat, 07 Sep 2024 18:52:49 +0300 Message-ID: <864j6rxxym.fsf@gnu.org> References: <1BF559D1-DB9F-4FEB-90ED-72E0EFD76424@gmail.com> <864jcrindg.fsf@gnu.org> <291DD5F1-85B8-4647-A40A-EBBD4C51E253@gmail.com> <8634sbijfx.fsf@gnu.org> <2CF47DA5-A65B-47C4-A28A-6FEE1469BD13@gmail.com> <86cyrdfuai.fsf@gnu.org> <3139C8FE-5C67-4FE3-B940-F449DA73E76C@gmail.com> <86le5zdfbi.fsf@gnu.org> <4C93E902-282D-4408-B449-C8E771B2B3E4@gmail.com> <86cyr7agjo.fsf@gnu.org> <850DEC32-F318-4F3E-BA87-55FC6DC74CD3@gmail.com> <86ikvpnbj5.fsf@gnu.org> <867cc5mbq3.fsf@gnu.org> <86y14kjw70.fsf@gnu.org> <86ikv7zzyo.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38050"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattias.engdegard@gmail.com, 70007@debbugs.gnu.org, casouri@gmail.com, stefankangas@gmail.com, monnier@iro.umontreal.ca To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 07 17:54:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smxm5-0009jJ-IC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Sep 2024 17:54:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smxlK-0004Qi-Fv; Sat, 07 Sep 2024 11:54:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smxlB-0004MH-RB for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 11:54:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smxlB-0002MI-I6 for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 11:54:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=0/k26vqxS5GXL1Ej2LjPsWMePeydFZtgNkXLF/Nmrls=; b=jlLE7uZvOLhxwRHrpzwlrQXN5UmdYMEEHvymsdtzX1/4jTLlNDH/9psXk6JmXpVHC73HRQheiotztEzcbrZ4ImVIhgnNDH5QddROK+8qPk7bQhF+K5Q00EjzKRviARA5AepMA8f4H3oDPeXksTC39J1P2tkVf19f5L3FPcUJwcpPb0YWhlZHYiyO534SBiMol/5G7wo7VpStITbPovs4vOQRiHv+4TaBVvP8bZ2yDXAzrzsbFUGrFpGRktCxH9AsJZuq2TXQaBKpniGEppkoAegivTSGzhtkqhVHc6+STEZA4xNLD9Ajm6ROdomez1jjf1N5S1xUW9EnmdyxZhN5Zg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smxlC-0004Ih-5k for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 11:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Sep 2024 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70007 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70007-submit@debbugs.gnu.org id=B70007.172572438716462 (code B ref 70007); Sat, 07 Sep 2024 15:54:02 +0000 Original-Received: (at 70007) by debbugs.gnu.org; 7 Sep 2024 15:53:07 +0000 Original-Received: from localhost ([127.0.0.1]:57254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smxkJ-0004HS-07 for submit@debbugs.gnu.org; Sat, 07 Sep 2024 11:53:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smxkG-0004Gw-Lp for 70007@debbugs.gnu.org; Sat, 07 Sep 2024 11:53:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smxk8-0002J3-F1; Sat, 07 Sep 2024 11:52:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0/k26vqxS5GXL1Ej2LjPsWMePeydFZtgNkXLF/Nmrls=; b=KMMLl3cLQ+Pj zZ+D8A56ij9GluyeLP513f9Bs+4jUAvNxMJ+LU48PYLc8ps70EaytOBcnM88ILstjnO6YCTtYkeJk dxbLOTxTqg/rgP+OSBy6jTDkxgqLHqgMBhjp1A63eRDQJrOtRQhIxIr3Ucpwin+5G/6EAUahFDxa1 nPbfK+6QDkTLXUnFxk8tRLG435AatqczCIpze2TAkkjil8HVEvClMw8OT0HOutCiZSji9UkkjlbxL MBv3skpdTr2Xg7mpK2s+v0gGfJKcFbzEasupOcVydwMZ8COMnW9X512gmMl2j9F6BpbIJa+1U6SjP Oh1N4mOk1Gnrw6W9u8M/8A==; In-Reply-To: (message from Andrea Corallo on Sat, 07 Sep 2024 11:48:36 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291398 Archived-At: > From: Andrea Corallo > Cc: Stefan Kangas , monnier@iro.umontreal.ca, > mattias.engdegard@gmail.com, casouri@gmail.com, 70007@debbugs.gnu.org > Date: Sat, 07 Sep 2024 11:48:36 -0400 > > Eli Zaretskii writes: > > >> From: Stefan Kangas > >> Date: Sat, 31 Aug 2024 15:15:25 -0700 > >> Cc: mattias.engdegard@gmail.com, acorallo@gnu.org, casouri@gmail.com, > >> 70007@debbugs.gnu.org > >> > >> Stefan Monnier writes: > >> > >> >> And against the additional variable to make this more > >> >> backward-compatible? > >> > > >> > Yup. The var would be my second-best choice (and I assume it's > >> > immediately declared obsolete). > >> > >> I tend to agree with Stefan M here. > > > > Thanks. > > > > Andrea, would you please voice your opinion on this? > > I'm for returning unibyte indeed. And for the variable or the second > function I'm kind of neutral, I'd do it only if it's not too much effort > so I'll trust Mattias preference here. OK, so let's go with unconditionally unibyte, as it seems to be the consensus here.