From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324) Date: Mon, 23 Sep 2024 21:24:41 +0300 Message-ID: <864j66fct2.fsf@gnu.org> References: <172663360099.23732.9998257239822693024@vcs2.savannah.gnu.org> <20240918042641.56C7BC410E2@vcs2.savannah.gnu.org> <87v7yt322l.fsf@yahoo.com> <87y13kz1ji.fsf@yahoo.com> <4A9D96DA-C260-46B6-A3BC-E2F4A9E5C8E2@gmail.com> <87tte7mlhh.fsf@gmail.com> <867cb2h9on.fsf@gnu.org> <87wmj2uvtu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19001"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, luangruo@yahoo.com, stefankangas@gmail.com, emacs-devel@gnu.org To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 23 20:24:53 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssnjx-0004kO-E6 for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Sep 2024 20:24:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssnjq-0001XO-JD; Mon, 23 Sep 2024 14:24:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssnjo-0001XB-O5 for emacs-devel@gnu.org; Mon, 23 Sep 2024 14:24:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssnjo-0004z0-Dl; Mon, 23 Sep 2024 14:24:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=W53ZQ2Ve1lH1QrRSGBJRNszZGQOemH0XKfVgSeOK/x4=; b=CVsjhGJDk8wXfDEz8WuM jc6UC9eiNjBW62g+5aA2vhSil+DHpAJvjtbMlfwUmM9qq3jUzlhA2vd22Kd+VWQJItR6BzNDwbb// +EiDz4pTvzSR36fgZHhIIo1aH9nuhK+4Gbjwkhi7yES3P4dphRReD2qEtjAOiXobh1taBh1cm+yyO xbZds8AqyHVWX9tch11Pvsn3yGjODq3lSIEhMi2CMcVsgO4/EfFcHcbNTzl25NPRIbIRN9ROo3cQd nlfbXfzwOq79js0uFCH1P/+AwkBjoqV82EDcSGus/20fdRYZlpzD/9mac8FIrP62sJQYLP+NJbQdQ mS/3EgjV41FmqA==; In-Reply-To: <87wmj2uvtu.fsf@gmail.com> (message from =?utf-8?Q?K=C3=A9vin?= Le Gouguec on Mon, 23 Sep 2024 19:24:45 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323990 Archived-At: > From: Kévin Le Gouguec > Cc: casouri@gmail.com, luangruo@yahoo.com, stefankangas@gmail.com, > emacs-devel@gnu.org > Date: Mon, 23 Sep 2024 19:24:45 +0200 > > > Isn't it a bug in magit that it doesn't do something like that > > already? Fill column is just the tip of an iceberg, because a log > > message is generally human-readable text, and so should benefit from > > other features of Text mode and its descendants, like spell-checking > > etc. > > It does try to do "something like that"; AFAIU the two main knobs are: > > * git-commit-major-mode lets users pick their preferred text-adjacent > major mode (or it lets maintainers choose it, e.g. setting that variable > in a checked-in .dir-locals.el; the default is text-mode), > > * git-commit-setup-hook lets users turn on useful log-editing features; > the defcustom includes various opt-in functions. Robert mentioned > magit-generate-changelog; there's also git-commit-turn-on-flyspell and > bug-reference-mode. > > (There's also a mysterious git-commit-setup-changelog-support that > checks for > > (fboundp 'log-indent-fill-entry) ; New in Emacs 27 > > but I can't find any trace of log-indent-fill-entry in the tree so not > sure what that's about) That sounds to me like a heap of patches when just having a full-blown mode like VC does would have done the job cleanly and seamlessly. > So what's "missing" from Magit's git-commit.el is a knob dedicated to > the fill-column for commit messages. I'm quite sure that soon enough someone will come with more "missing" stuff. I still think they should use something very similar to log-edit-mode there. It doesn't make much sense not to. E.g., the .dir-locals settings would have been in effect for magit users as well.