From: Eli Zaretskii <eliz@gnu.org>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: casouri@gmail.com, luangruo@yahoo.com, stefankangas@gmail.com,
emacs-devel@gnu.org
Subject: Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324)
Date: Mon, 23 Sep 2024 21:24:41 +0300 [thread overview]
Message-ID: <864j66fct2.fsf@gnu.org> (raw)
In-Reply-To: <87wmj2uvtu.fsf@gmail.com> (message from Kévin Le Gouguec on Mon, 23 Sep 2024 19:24:45 +0200)
> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Cc: casouri@gmail.com, luangruo@yahoo.com, stefankangas@gmail.com,
> emacs-devel@gnu.org
> Date: Mon, 23 Sep 2024 19:24:45 +0200
>
> > Isn't it a bug in magit that it doesn't do something like that
> > already? Fill column is just the tip of an iceberg, because a log
> > message is generally human-readable text, and so should benefit from
> > other features of Text mode and its descendants, like spell-checking
> > etc.
>
> It does try to do "something like that"; AFAIU the two main knobs are:
>
> * git-commit-major-mode lets users pick their preferred text-adjacent
> major mode (or it lets maintainers choose it, e.g. setting that variable
> in a checked-in .dir-locals.el; the default is text-mode),
>
> * git-commit-setup-hook lets users turn on useful log-editing features;
> the defcustom includes various opt-in functions. Robert mentioned
> magit-generate-changelog; there's also git-commit-turn-on-flyspell and
> bug-reference-mode.
>
> (There's also a mysterious git-commit-setup-changelog-support that
> checks for
>
> (fboundp 'log-indent-fill-entry) ; New in Emacs 27
>
> but I can't find any trace of log-indent-fill-entry in the tree so not
> sure what that's about)
That sounds to me like a heap of patches when just having a full-blown
mode like VC does would have done the job cleanly and seamlessly.
> So what's "missing" from Magit's git-commit.el is a knob dedicated to
> the fill-column for commit messages.
I'm quite sure that soon enough someone will come with more "missing"
stuff. I still think they should use something very similar to
log-edit-mode there. It doesn't make much sense not to. E.g., the
.dir-locals settings would have been in effect for magit users as
well.
next prev parent reply other threads:[~2024-09-23 18:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172663360099.23732.9998257239822693024@vcs2.savannah.gnu.org>
[not found] ` <20240918042641.56C7BC410E2@vcs2.savannah.gnu.org>
2024-09-18 6:31 ` emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324) Po Lu
2024-09-20 4:53 ` Yuan Fu
2024-09-20 6:32 ` Eli Zaretskii
2024-09-20 6:44 ` Eli Zaretskii
2024-09-21 3:10 ` Yuan Fu
2024-09-22 0:59 ` Stefan Kangas
2024-09-22 5:18 ` Eli Zaretskii
2024-09-22 5:43 ` Po Lu
2024-09-22 6:44 ` Yuan Fu
2024-09-22 21:23 ` Kévin Le Gouguec
2024-09-23 8:27 ` Robert Pluim
2024-09-23 11:49 ` Eli Zaretskii
2024-09-23 17:24 ` Kévin Le Gouguec
2024-09-23 18:24 ` Eli Zaretskii [this message]
2024-09-24 7:10 ` Kévin Le Gouguec
2024-09-26 7:28 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864j66fct2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=kevin.legouguec@gmail.com \
--cc=luangruo@yahoo.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.