From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74157: 30.0.92; `emacsclient-program-name' doesn't factor Emacs name changes Date: Fri, 01 Nov 2024 16:57:23 +0200 Message-ID: <864j4r0zos.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74157@debbugs.gnu.org To: Jerome Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 01 15:58:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t6t72-0002qu-4Q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Nov 2024 15:58:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6t6i-0007sI-3D; Fri, 01 Nov 2024 10:58:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6t6B-0007Mz-4l for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2024 10:58:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6t6A-000710-L6 for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2024 10:58:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=YagPJ6PPLOKnHqmd5M4+n2j3M1nKmf9vpoBHC1el5Z0=; b=uIvHEFnHzLtjfraK6bYVc+szEvVP7fzVWCSen3Mf3f2U6+AF2zC8OXkx5r9doJ3nGs3qVguO7S7sZOXCLuEvkOL/7eU+OlrCSym2zIusFP1liaI5qZn50dd780s4ry5irpiFHVJS0x1CqS4n9vTEE31p2enT4LetueRCqKOcWnxIXWG8Org9qvPe7Rzy5FjHsNw5nc9hgVfJ5I3LvSaImyxipj56CYqXhf0PLEilHUnuls6pTIlvZGk0iysRGnTL3ZN13qRpaz63YZTwwlRyVLRrdjiaLhrSSWYNatN7QWQElI9nTeR0RPM9OiSd0kSMtwDFd0yztkUwRwEVu6b0gg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6t6A-0003rX-3N for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2024 10:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Nov 2024 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74157 X-GNU-PR-Package: emacs Original-Received: via spool by 74157-submit@debbugs.gnu.org id=B74157.173047305914830 (code B ref 74157); Fri, 01 Nov 2024 14:58:02 +0000 Original-Received: (at 74157) by debbugs.gnu.org; 1 Nov 2024 14:57:39 +0000 Original-Received: from localhost ([127.0.0.1]:49993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6t5m-0003r8-SJ for submit@debbugs.gnu.org; Fri, 01 Nov 2024 10:57:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6t5l-0003r2-4K for 74157@debbugs.gnu.org; Fri, 01 Nov 2024 10:57:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6t5f-0006eo-NM; Fri, 01 Nov 2024 10:57:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YagPJ6PPLOKnHqmd5M4+n2j3M1nKmf9vpoBHC1el5Z0=; b=WRIzDDRav9w9 2iHGLYD+KapNOWEhCMqQCAcLiMmy0uimTmobALOsSy3thToZuTcJhNIL6Ur+nV5yeDY0fm2pOSzQA uzOQDRxCH4L7wsN/uDZYhAb6sn5kggRTqj4CfeRqqkkvdoutIQBumTEln0/FufsIF4TiXNorirgGB jTCxSOJwQx9EkmwxyRLdsUuiBf/os+qgCddyxsCHIJlJU3PJcaxgLUBfqjQTi/PnR6cU2EfUyTS0g YXdLZBMjBPZGeig5FIEqr/kHry8b7cGIzERmk/icome21Mv1EUn/V5BBJi/Zlb7xB+vViwHkpNkAc Hx5yU9LdR8u9bvoqY6M+Sw==; In-Reply-To: (message from Jerome on Fri, 1 Nov 2024 16:51:32 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294685 Archived-At: > Date: Fri, 1 Nov 2024 16:51:32 +0900 > From: Jerome > > Emacs 30 adds the `emacsclient-program-name', but its default value > doesn't factor the build time Emacs name configuration changes (with > prefix, suffix and sed transormation). I only verified this with the > suffix confguration, but assume prefix and sed transformation are the > same. > > In my case I configured with `--program-suffix=-30pre'. The Emacs client > program is, as expected, `emacsclient-30pre', but the value of > `emacsclient-program-name' is still `'emacsclient'. The variable value > should reflect the configure time name change(s). It's actually more complex than that: the programs are renamed only when Emacs is installed, not when Emacs is built. So when Emacs is run from the build tree, this variable should have its original name, and only when Emacs is run from its installed location, the name should reflect the transform. Which means the name transformation cannot be static, at build time; it must be done at run time when we take note of invocation-name. > This would make `with-editor' simpler (from Emacs 30 onward) as no > heuristics would be needed to derive the Emacs client name. See: > https://github.com/magit/with-editor/issues/132 It's too late for Emacs 30 for such non-trivial changes, unfortunately. So we can only improve this in Emacs 31.