From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown Date: Sat, 09 Nov 2024 18:33:05 +0200 Message-ID: <864j4gmkou.fsf@gnu.org> References: <20241031.160649.1619221016115134543.enometh@meer.net> <86msi8n1jd.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4690"; mail-complaints-to="usenet@ciao.gmane.io" Cc: enometh@meer.net, 74132@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 09 17:34:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t9oPk-00014w-Gz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Nov 2024 17:34:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9oPU-0007Bx-NI; Sat, 09 Nov 2024 11:34:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9oPT-0007Bg-CO for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 11:34:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t9oPS-0008Ro-Hl for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 11:34:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=bx78JHNjSp1NABYHMUhEGXMzWG1EMKFXDZmZCr7T8NU=; b=RgrVqK0Uim9YjJdfyak7tYLJQxp9AnXGhVqreiDT5FG042zt8hEcTb85rgBcQK0Hy7/MfKgL/XPIu96GiK/XVws+G00NfMdy++1rzKQNblYGnyTN2pnAFPLp0yk9j7oitbsPOLyj46wjzDgSmNL4v5SKA/6FVIL5Q1ikQwSyibt8yXppIQa/Q29OwAB4+XNYH0Q8oqpusQDuZ8ygAhvAmht+GHcye+t28KCwBRdF4Rfe/IdzvOxHEL+1x0lkI3DR3y1mSGhoFYXiwCy4m1CtGPzanfcXeyri1gSC1iPoUatj4L/VYqOVbacUkUUVUPuqTjcIkQ/gnMVhG1YiGGVatg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t9oPS-00040P-4j for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 11:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Nov 2024 16:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74132 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74132-submit@debbugs.gnu.org id=B74132.173116999815346 (code B ref 74132); Sat, 09 Nov 2024 16:34:02 +0000 Original-Received: (at 74132) by debbugs.gnu.org; 9 Nov 2024 16:33:18 +0000 Original-Received: from localhost ([127.0.0.1]:54215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9oOj-0003zR-VU for submit@debbugs.gnu.org; Sat, 09 Nov 2024 11:33:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9oOg-0003zD-VP for 74132@debbugs.gnu.org; Sat, 09 Nov 2024 11:33:15 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9oOb-0008Pq-Fg; Sat, 09 Nov 2024 11:33:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bx78JHNjSp1NABYHMUhEGXMzWG1EMKFXDZmZCr7T8NU=; b=VAtkW2TYRq7L OP2Kn4OAfgvbmsd1TQw5CxLFR7zl6RMAG3QPUm5rT6G8dLIN1+mvb0wk/D8ppy9UqzBv9DRCGvPH8 IVxjjb51H5eiZq6CqneTpLBAfW3xoKSE+86jkEc860egVeKoPiZ7d67y7CX+ZWGNAr6H4SLggqiSC nV+cleprXnOunDE4bEVfyQuXUVMI3DlsgEEh0c57wM7QqbiG5EURLfwJN+DN6M1NtIPxvjs78UglT IZUUtp4tF8s5dgYBoV2M1uHxo73C6F+5/MwZh+IbtsN/xJOxcCdyxH6Bq2bHSYP3c3vaQd7yVlY1m nLRUeTSzxk7yMJ5bbBkTYA==; In-Reply-To: (message from Stefan Monnier on Sat, 09 Nov 2024 10:52:06 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295142 Archived-At: > From: Stefan Monnier > Cc: Madhu , 74132@debbugs.gnu.org > Date: Sat, 09 Nov 2024 10:52:06 -0500 > > > What will this do to URLs such as > > > > http://web.archive.org/web/20240221082647/https://www.imdb.com/ > > Depends where point is: if it's after the `https`, then you get the > "sub-URL" and if it's on or before the `https` then you get the whole URL. Exactly. This could be considered a bug, because the actual URL is the entire thing. > > I'm not sure I see how to resolve this dilemma. Stefan, any ideas? > > "url at point" is inherently heuristic, so I'm not too worried. > But I do very much agree with Stefan that we need tests, because it's > all too easy to run around in circles otherwise, fixing the heuristic to > handle case A but breaking case B along the way. I'm okay with adding tests, of course, but I'm not sure which of the two behaviors leave you "not too worried": the current or the new one after the proposed change. And why.