From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74630: 31.0.50; emacs-mail-verify Date: Wed, 04 Dec 2024 15:26:15 +0200 Message-ID: <864j3j1sw8.fsf@gnu.org> References: <868qsz5ztx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12091"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74630@debbugs.gnu.org To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 04 14:27:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIpPT-00031c-Am for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Dec 2024 14:27:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIpPE-0002qz-1d; Wed, 04 Dec 2024 08:27:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIpPD-0002qn-51 for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 08:27:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIpPC-0003zy-RY for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 08:27:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=UqlNJwskhKvkFMEAhO8WyLm2HWqnfPoRhmw1Qv5fk3U=; b=kwT0Ec/qFq8Ud0NTYskaDMxs9xiYlv0S439Iok0+4+gfTE3NMVGafIqaXvuyCxXUDlcdThwR5Qjm2SDfaXxYybKlM+WGudoXc23vdWk6fUI9qyQ/yQ+YlCm+7Uab2/tFDcSvBGJkG/Gubw6U4x1RcGofOzD11llpH5S2WESug+5TIwOzXjeCT1eGUMlxRqSAxreqt6AsH7W6+r5r7TLFWKfQxcy3UItZewTceF7PnNnVpoza53tREr/W19Qe/c/5CJ60JT6Mss6FV5MtAY4IGrQNIqIfI6PJmtQe01Qq9rldBZ0U+Dprspz8pA39odP+yw0cb85hSndr+hFAaF1Rpw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tIpPC-0001Gn-Ew for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 08:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Dec 2024 13:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74630 X-GNU-PR-Package: emacs Original-Received: via spool by 74630-submit@debbugs.gnu.org id=B74630.17333188124858 (code B ref 74630); Wed, 04 Dec 2024 13:27:02 +0000 Original-Received: (at 74630) by debbugs.gnu.org; 4 Dec 2024 13:26:52 +0000 Original-Received: from localhost ([127.0.0.1]:34657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIpP1-0001GF-Hu for submit@debbugs.gnu.org; Wed, 04 Dec 2024 08:26:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIpOz-0001G0-ET for 74630@debbugs.gnu.org; Wed, 04 Dec 2024 08:26:49 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIpOd-0003gb-Jt for 74630@debbugs.gnu.org; Wed, 04 Dec 2024 08:26:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UqlNJwskhKvkFMEAhO8WyLm2HWqnfPoRhmw1Qv5fk3U=; b=rgZ9lTVsGMxZ 3FWJM8TXxBqbyxth+PV+e2yqFOawvj7qtiYYqnR/eTnMplOdZXK4djuZf5T+4xlfZsuTojI670Fum NhWoRykprOWoUlEx86j8kmyDdxg7Ud1Kmhr7g0LzyP0Zo8HmapemxVtQa8QhDsEzOwHR7Mk34nNWe 4N/Yp9lc+hkyINdzOwBU1hzSblJKB4dmEaqkbS+NgR0DZXOOAL9O8b+VkcXSZBt9dEV1Xdd+Gkvfy Jq+Z1ZjatxlcY6d6zNdViulaWc6n0TLPAI5sUnoT8zfN1O1cUz9VMxRJ8OXf+0fOAtKCFuZpBdCfE gLkj/MpH5VJpQGL7bHhl7g==; In-Reply-To: (message from Richard Stallman on Wed, 04 Dec 2024 01:09:05 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296410 Archived-At: > From: Richard Stallman > Cc: 74630@debbugs.gnu.org > Date: Wed, 04 Dec 2024 01:09:05 -0500 > > > Not sure what you expected the doc string to say. Would the below be > > enough? > > > Verify OpenPGP cleartext signed messages in the current buffer. > > The buffer is expected to contain a mail message. > > > If the verification fails, the command signals an error. > > That is better, becauee it gives enough information to deduce what > indicates success. But the user should need to do any deduction about > that, let alone read code and guess what some other functions do. Thanks, I installed a change along those lines. > To make the doc string truly clear, it should say explicitly what > indicates success. That way the user can know, rather than just > supposing. I don't know how to describe success in this case, except as the lack of an error. > Should the function be changed to display a message, "Signature verified", > on success? It says "Verifying...done", which I think is enough (and quite standard in Emacs). > Do some people run this function from a hook for every message and > want to see output only in case of failure? See above: it displays a message in case of success as well. > Should it a value indicating success or failure? I don't know. The values of the relevant functions don't seem to be documented.