From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list Date: Wed, 08 Jan 2025 15:02:11 +0200 Message-ID: <864j294fxo.fsf@gnu.org> References: <87h66e8u59.fsf@gmail.com> <5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12917"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75362@debbugs.gnu.org, dev@rjt.dev, jroi.martin@gmail.com To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 08 14:04:24 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVVjS-0003DI-T9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jan 2025 14:04:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVViD-0002vw-GT; Wed, 08 Jan 2025 08:03:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVViA-0002ox-W3 for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 08:03:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVViA-0001JL-Mi for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 08:03:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=25OUl3bMEx3rm/o6RBzHfhsBSgA+5sRV/OC6UryN6ZU=; b=lYzeIFIP1UfhQDgMdzzvD+HEaHwdkzxz70C4rjWTpB3CRzYdUjyfFLFv4Bvkd+FO2boNSuqzBAVk3CvIKNmqnI1FxgDyqLJ9MCMQ7x7/N44EFiL0MgifqnhaIS/nMFWH348LLxwjuyz/M3lJSArSrdGyHIF8Av7VKtVhmGpCEs0jUrTdo3/2W24pHDcEpV5NgbbqSlZVmrUSyIHMoKaoNHlSX2RvcSwuZmBXOtojC6BvWqrMmk1ncPXDSxQkrZewRVrRbNfAFLe+2IcAE+LtR0mLtK5OK/+2iexKkkbwu+CmEkZRBof4qB9wD/Gndi2bw593Rop696ONvJfo8acrQA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVViA-0001h7-GH for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 08:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2025 13:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75362 X-GNU-PR-Package: emacs Original-Received: via spool by 75362-submit@debbugs.gnu.org id=B75362.17363413466459 (code B ref 75362); Wed, 08 Jan 2025 13:03:02 +0000 Original-Received: (at 75362) by debbugs.gnu.org; 8 Jan 2025 13:02:26 +0000 Original-Received: from localhost ([127.0.0.1]:46406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVVhZ-0001g6-NA for submit@debbugs.gnu.org; Wed, 08 Jan 2025 08:02:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39782) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVVhY-0001ft-Ag for 75362@debbugs.gnu.org; Wed, 08 Jan 2025 08:02:24 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVVhS-0001Ai-J9; Wed, 08 Jan 2025 08:02:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=25OUl3bMEx3rm/o6RBzHfhsBSgA+5sRV/OC6UryN6ZU=; b=eP6ZCxLLnACUd8x1EpqH p/m+6qX5P5LtJVLiHZ2xKvdXoO0FHWGMS3JmNe/3zDdkTmwdpBbo1Ots+8rOPuRovFB3wXBXqTkxC UCuSGQsGc+17unmZ/mPpQX8c97aNBy2CpVoie3GAN37QJ6BBoxGbCpUtPnbe0NR4GCgATklNY8vi1 X6Lq8zwevjejn+3++nMQvAya+dhFt3H1wtAf70KQHVwVQJmQcsEq1X2GbyzqilWjjN74+lQqO7A16 CLlTzjot5gAf7xI8sHL/SLltJ6yUDsGHZRItewNvLzisMMhC+DL+eWGUrGQpRmqA3CyujMWk8/rBA 3772Mjh9yD0l6Q==; In-Reply-To: <5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com> (message from Yuan Fu on Tue, 7 Jan 2025 22:18:53 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298774 Archived-At: > Cc: 75362@debbugs.gnu.org, Roi Martin > From: Yuan Fu > Date: Tue, 7 Jan 2025 22:18:53 -0800 > > > The attached patch fixes it for me.<0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch> > > Thanks Randy. Eli, should we apply this to emacs-30. Is this backward-compatible to older grammars? If yes, it's okay to install on emacs-30. If it is not compatible, I'd like to see how a compatible patch will look before I decide. > Also, what’s the general situation of grammar fixes on emacs-30? I’m asking because I fixed a grammar compatibility issue for cmake-ts-mode on master. I was going to back port it for 30.2, but it seems that simple fixes are ok for emacs-30? Please tell the commit, and I will look at it.