From: Christoph Scholtes <cschol2112@googlemail.com>
To: emacs-devel@gnu.org
Subject: Advising quit-window
Date: Tue, 25 Oct 2011 19:54:09 -0600 [thread overview]
Message-ID: <8639eg8qm6.fsf@googlemail.com> (raw)
Sorry to dwell on `quit-window', but...
I really don't like the default behavior of `quit-window' burying the
buffer instead of killing it. I'd much rather have the default be kill
than bury, especially when it is bound to `q'.
Therefore, I have this in my .emacs:
;; Advise quit-window to kill buffer instead of burying it
(defadvice quit-window (before advise-quit-window activate)
(ad-set-arg 0 (not (ad-get-arg 0))))
This works fine for cases where `quit-window' is bound to, for example,
`q' in a keymap. However, `quit-window' is also called internally, for
example by `quit-windows-on'. The latter is then called by vc mode to
kill the log buffer after a commit. It took me a while to figure out
that my advice actually caused the log buffer to be buried now, instead
of killed.
Can we please have a user option to select whether the default behavior
is kill or bury? Or can we add a `quit-window-internal' and
`quit-window' then calls `quit-window-internal'? I can then advise
`quit-window' to get the behavior I want without affecting the internal
function.
Other solutions welcome.
Christoph
next reply other threads:[~2011-10-26 1:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 1:54 Christoph Scholtes [this message]
2011-10-26 2:23 ` Advising quit-window Juanma Barranquero
2011-10-26 2:52 ` Christoph Scholtes
2011-10-26 9:21 ` martin rudalics
2011-10-27 3:53 ` Christoph Scholtes
2011-10-27 9:54 ` martin rudalics
2011-10-26 13:54 ` Stefan Monnier
2011-10-27 3:55 ` Christoph Scholtes
2011-10-27 6:43 ` Juri Linkov
2011-10-27 12:06 ` Christoph Scholtes
2011-10-27 12:23 ` Stefan Monnier
2011-10-29 3:57 ` Christoph Scholtes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8639eg8qm6.fsf@googlemail.com \
--to=cschol2112@googlemail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.