all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Deniz Dogan <deniz@dogan.se>
To: 11186@debbugs.gnu.org
Subject: bug#11186: 24.0.92; ERC: Better names for the different log file name formats
Date: Thu, 05 Apr 2012 19:56:30 +0200	[thread overview]
Message-ID: <86398i2hbl.fsf@dogan.se> (raw)

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

I think the names of the different log file name formats could be
improved a lot.  There's basically nothing that tells the ordinary user
what the different log formats imply.  Attached is a patch which changes
the name to be more verbose about what the formats mean.

Note that I have used #channel instead of "target" or "buffer" in this
patch, because the ordinary user will most likely understand that
#channel could very well be an IRC user as well.

[-- Attachment #2: Patch --]
[-- Type: text/plain, Size: 948 bytes --]

=== modified file 'lisp/erc/erc-log.el'
--- lisp/erc/erc-log.el	2012-01-19 07:21:25 +0000
+++ lisp/erc/erc-log.el	2012-04-05 17:53:30 +0000
@@ -113,9 +113,9 @@
 custom function which returns the directory part and set
 `erc-log-channels-directory' to its name."
   :group 'erc-log
-  :type '(choice (const :tag "Long style" erc-generate-log-file-name-long)
-		 (const :tag "Long, but with network name rather than server"
+  :type '(choice (const :tag "#channel!nick@server:port.txt" erc-generate-log-file-name-long)
+		 (const :tag "#channel!nick@network.txt"
 			erc-generate-log-file-name-network)
-		 (const :tag "Short" erc-generate-log-file-name-short)
-		 (const :tag "With date" erc-generate-log-file-name-with-date)
+		 (const :tag "#channel.txt" erc-generate-log-file-name-short)
+		 (const :tag "#channel@date.txt" erc-generate-log-file-name-with-date)
 		 (function :tag "Other function")))

 (defcustom erc-truncate-buffer-on-save nil

             reply	other threads:[~2012-04-05 17:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-05 17:56 Deniz Dogan [this message]
2012-10-07  2:05 ` bug#11186: 24.0.92; ERC: Better names for the different log file name formats Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86398i2hbl.fsf@dogan.se \
    --to=deniz@dogan.se \
    --cc=11186@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.