all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stephen Leake <stephen_leake@stephe-leake.org>
To: "Grégoire Jadi" <gregoire.jadi@univ-nantes.fr>
Cc: 21764@debbugs.gnu.org
Subject: bug#21764: 25.0.50; bibtex-set-dialect not called for bibtex buffers
Date: Thu, 12 Nov 2015 12:33:29 -0600	[thread overview]
Message-ID: <8637wbdq4m.fsf@stephe-leake.org> (raw)
In-Reply-To: <87fv0bb7tr.fsf@univ-nantes.fr> ("Grégoire Jadi"'s message of "Thu, 12 Nov 2015 15:39:28 +0100")

Grégoire Jadi <gregoire.jadi@univ-nantes.fr> writes:

> Below a patch that fixes this bug and with regression tests.

Thanks for writing the test.

This needs a comment on why bibtex-set-dialect is being called, when it
is also being added to the hook. Better would be to check if there is a
file associated with the current buffer.

This sets the global value of bibtex-* variables; is that appropriate?

-- 
-- Stephe





  reply	other threads:[~2015-11-12 18:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26 15:49 bug#21764: 25.0.50; bibtex-set-dialect not called for bibtex buffers Grégoire Jadi
2015-11-12 14:39 ` Grégoire Jadi
2015-11-12 18:33   ` Stephen Leake [this message]
2020-08-12 12:34     ` Lars Ingebrigtsen
2020-08-19 13:36       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8637wbdq4m.fsf@stephe-leake.org \
    --to=stephen_leake@stephe-leake.org \
    --cc=21764@debbugs.gnu.org \
    --cc=gregoire.jadi@univ-nantes.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.