From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthew Leach Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v3] Add systemd socket launching support Date: Thu, 31 Mar 2016 17:38:51 +0000 Message-ID: <8637r6a6ok.fsf@mattleach.net> References: <874mbn7kmn.fsf@mattleach.net> <871t6qkc3h.fsf@mattleach.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1459445972 16626 80.91.229.3 (31 Mar 2016 17:39:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Mar 2016 17:39:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 31 19:39:24 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1algYz-0007Fo-Hy for ged-emacs-devel@m.gmane.org; Thu, 31 Mar 2016 19:39:21 +0200 Original-Received: from localhost ([::1]:33614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1algYv-0003Pm-L5 for ged-emacs-devel@m.gmane.org; Thu, 31 Mar 2016 13:39:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1algYd-0003P8-GI for emacs-devel@gnu.org; Thu, 31 Mar 2016 13:39:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1algYY-0000rE-Ga for emacs-devel@gnu.org; Thu, 31 Mar 2016 13:38:59 -0400 Original-Received: from mx0.mattleach.net ([176.58.118.143]:43554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1algYY-0000qv-Ar for emacs-devel@gnu.org; Thu, 31 Mar 2016 13:38:54 -0400 Original-Received: by mx0.mattleach.net (Postfix, from userid 99) id 6BCEA6222E; Thu, 31 Mar 2016 18:38:53 +0100 (BST) Original-Received: from buxton.mattleach.net (host81-159-23-200.range81-159.btcentralplus.com [81.159.23.200]) by mx0.mattleach.net (Postfix) with ESMTPSA id AAD526222B; Thu, 31 Mar 2016 18:38:52 +0100 (BST) In-Reply-To: (Stefan Monnier's message of "Thu, 31 Mar 2016 13:11:25 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 176.58.118.143 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202518 Archived-At: Hi Stefan, Thanks for taking a look. Stefan Monnier writes: >> Internally, sd_listen_fds() checks whether the $LISTEN_PID environment >> variable equals the daemon PID. If not, it returns >> immediately. Otherwise, it parses the number passed in the $LISTEN_FDS >> environment variable, then sets the FD_CLOEXEC flag for the parsed >> number of file descriptors starting from SD_LISTEN_FDS_START. Finally, >> it returns the parsed number. > > Then I think it would be better to follow an approach like the one with > which you started (i.e. without the internal systemd_socket variable), Could I clarify, would you like me to expose these variables to lisp, like I did in v1 of the patches? Or make the internal variable names non-systemd specific? -- Matt