From: Matthew Leach <matthew@mattleach.net>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH v3] Add systemd socket launching support
Date: Thu, 31 Mar 2016 17:38:51 +0000 [thread overview]
Message-ID: <8637r6a6ok.fsf@mattleach.net> (raw)
In-Reply-To: <jwvfuv6pobm.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 31 Mar 2016 13:11:25 -0400")
Hi Stefan,
Thanks for taking a look.
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> Internally, sd_listen_fds() checks whether the $LISTEN_PID environment
>> variable equals the daemon PID. If not, it returns
>> immediately. Otherwise, it parses the number passed in the $LISTEN_FDS
>> environment variable, then sets the FD_CLOEXEC flag for the parsed
>> number of file descriptors starting from SD_LISTEN_FDS_START. Finally,
>> it returns the parsed number.
>
> Then I think it would be better to follow an approach like the one with
> which you started (i.e. without the internal systemd_socket variable),
Could I clarify, would you like me to expose these variables to lisp,
like I did in v1 of the patches? Or make the internal variable names
non-systemd specific?
--
Matt
next prev parent reply other threads:[~2016-03-31 17:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 20:53 [PATCH v3] Add systemd socket launching support Matthew Leach
2016-03-31 12:55 ` Stefan Monnier
2016-03-31 13:31 ` Matthew Leach
2016-03-31 17:11 ` Stefan Monnier
2016-03-31 17:38 ` Matthew Leach [this message]
2016-03-31 17:41 ` Eli Zaretskii
2016-03-31 18:14 ` Stefan Monnier
2016-03-31 19:27 ` Matthew Leach
2016-03-31 19:32 ` Matthew Leach
2016-03-31 19:34 ` Eli Zaretskii
2016-03-31 21:22 ` Stefan Monnier
2016-04-01 7:10 ` Eli Zaretskii
2016-04-01 13:17 ` Stefan Monnier
2016-04-01 13:41 ` Eli Zaretskii
2016-04-01 18:43 ` Stefan Monnier
2016-04-01 19:47 ` Matthew Leach
2016-04-01 19:58 ` Eli Zaretskii
2016-04-03 0:53 ` Live System User
2016-03-31 16:32 ` Eli Zaretskii
2016-03-31 16:51 ` Matthew Leach
2016-03-31 16:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8637r6a6ok.fsf@mattleach.net \
--to=matthew@mattleach.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.