From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Brinkhoff Newsgroups: gmane.emacs.devel Subject: Re: User-defined record types, v2 Date: Sat, 18 Mar 2017 20:33:12 +0100 Organization: nocrew Message-ID: <8637eatm6f.fsf@molnjunk.nocrew.org> References: <86y3w2tt2n.fsf@molnjunk.nocrew.org> <86tw6qtt01.fsf@molnjunk.nocrew.org> <86k27mtsnv.fsf@molnjunk.nocrew.org> <86fuiatsh3.fsf@molnjunk.nocrew.org> <86bmsyts9f.fsf@molnjunk.nocrew.org> <8337eaxzc3.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489865634 27222 195.159.176.226 (18 Mar 2017 19:33:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Mar 2017 19:33:54 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 18 20:33:51 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpK6h-0005nh-F3 for ged-emacs-devel@m.gmane.org; Sat, 18 Mar 2017 20:33:43 +0100 Original-Received: from localhost ([::1]:54485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpK6k-0003DO-Fh for ged-emacs-devel@m.gmane.org; Sat, 18 Mar 2017 15:33:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpK6b-0003C8-Mb for emacs-devel@gnu.org; Sat, 18 Mar 2017 15:33:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpK6X-00009y-MU for emacs-devel@gnu.org; Sat, 18 Mar 2017 15:33:37 -0400 Original-Received: from [195.159.176.226] (port=46997 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cpK6X-00009f-G1 for emacs-devel@gnu.org; Sat, 18 Mar 2017 15:33:33 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cpK6G-0003Ee-4O for emacs-devel@gnu.org; Sat, 18 Mar 2017 20:33:16 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 21 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:HZtMuAMOvB/e96yxgRbo2wTw0MQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213139 Archived-At: Eli Zaretskii wrote: > I hope you will add documentation and some tests at some future point. I certainly will. > A few minor comments below. Thank you. I'm adding new commits to adress all your comments. >> +INLINE void >> +CHECK_RECORD_TYPE (Lisp_Object x) >> +{ >> + /* CHECK_SYMBOL (x); */ >> +} > > ??? This is still a work in progress. I initially added this function to check everywhere that the first slot is a valid defstruct type name. But then Stefan Monnier added support for EIEIO instances and made the first slot be a class object.