From: ashish.is@lostca.se (Ashish SHUKLA)
To: Eli Zaretskii <eliz@gnu.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
npostavs@gmail.com, ashish.is@lostca.se, emacs-devel@gnu.org
Subject: Re: Emacs HEAD broken with XPM option in 1b492fa
Date: Tue, 05 Sep 2017 00:53:52 +0530 [thread overview]
Message-ID: <863782jmif.fsf@chateau.d.if> (raw)
In-Reply-To: <867exejmrm.fsf@chateau.d.if> (Ashish SHUKLA's message of "Tue, 05 Sep 2017 00:48:21 +0530")
[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]
On Tue, 05 Sep 2017 00:48:21 +0530, ashish.is@lostca.se (Ashish SHUKLA) said:
| On Mon, 04 Sep 2017 21:30:13 +0300, Eli Zaretskii <eliz@gnu.org> said:
| || From: Paul Eggert <eggert@cs.ucla.edu>
| || Date: Mon, 4 Sep 2017 10:50:37 -0700
| || Cc: Noam Postavsky <npostavs@gmail.com>
| ||
| || > It seems like in e88bbd22[2], author (cc'ed) typo-ed (s/X11/noX/):
| ||
| || A comment before that line says:
| ||
| || ### The Cygwin-w32 build uses <noX/xpm.h> instead of <X11/xpm.h>, so
| || ### we need to set LDFLAGS accordingly.
| ||
| || so presumably the noX is intentional. Perhaps this depends on Cygwin versions?
| || Sorry, I can't be of much help here since I don't use Cygwin.
| | The OP was evidently compiling for FreeBSD, so I wonder how that
| | compilation ends up in a Cygwin-specific part of the configure
| | script. I guess some configure-time logic misfires on FreeBSD?
| Well, if you look carefully, there are two checks involving "noX/xpm.h" code
| snippet, one is for Windows/non-X11, and another is for X11. And,
| unfortunately both of those checks check for "noX/xpm.h", which I think is
| unintentional, and typo on author's part.
At following lines to be precise:
http://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac#n3326
http://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac#n3356
--
Ashish SHUKLA
“Nuclear war can ruin your whole compile.”
("Karl Lehenbauer")
Sent from my Emacs
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-09-04 19:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 21:45 Emacs HEAD broken with XPM option in 1b492fa Ashish SHUKLA
2017-09-04 17:50 ` Paul Eggert
2017-09-04 18:30 ` Eli Zaretskii
2017-09-04 19:18 ` Ashish SHUKLA
2017-09-04 19:23 ` Ashish SHUKLA [this message]
2017-09-05 0:45 ` Ken Brown
2017-09-05 1:48 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863782jmif.fsf@chateau.d.if \
--to=ashish.is@lostca.se \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.