From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Fri, 03 Aug 2018 11:07:06 +0100 Message-ID: <8636vv7ohh.fsf@gmail.com> References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <86in4resc8.fsf@gmail.com> <831sbfvl11.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533290754 17428 195.159.176.226 (3 Aug 2018 10:05:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Aug 2018 10:05:54 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 03 12:05:50 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flWxv-0004Of-FR for ged-emacs-devel@m.gmane.org; Fri, 03 Aug 2018 12:05:47 +0200 Original-Received: from localhost ([::1]:49980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flX02-0004qO-77 for ged-emacs-devel@m.gmane.org; Fri, 03 Aug 2018 06:07:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flWzQ-0004qE-Rv for emacs-devel@gnu.org; Fri, 03 Aug 2018 06:07:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flWzN-00045x-LQ for emacs-devel@gnu.org; Fri, 03 Aug 2018 06:07:20 -0400 Original-Received: from [195.159.176.226] (port=36509 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1flWzN-000448-Cb for emacs-devel@gnu.org; Fri, 03 Aug 2018 06:07:17 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1flWxD-0003f8-7z for emacs-devel@gnu.org; Fri, 03 Aug 2018 12:05:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 87 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:194F7EpFD9c8A5gJQkSY3q+OJ60= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228121 Archived-At: On Fri 03 Aug 2018, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Fri, 03 Aug 2018 10:01:59 +0100 >> >> > I believe your changes also cover the 32-bit MinGW build with wide ints. >> >> I expect so, but the build fails for 32bit MinGW builds on bignum branch >> with gettimeofday problems. I have a feeling that this has already been >> fixed on the master branch some time ago. > > Could be, but can you show the error messages? On the bignum ranch for 32bit MinGW I get: make -C lib all make[1]: Entering directory `/c/emacs/git/emacs/bignum/build/mingw32/lib' CC gettimeofday.o In file included from c:/emacs/git/emacs/bignum/lib/gettimeofday.c:23:0: c:/emacs/git/emacs/bignum/nt/inc/sys/time.h:11:19: error: field 'it_interval' has incomplete type struct timeval it_interval; /* timer interval */ ^~~~~~~~~~~ c:/emacs/git/emacs/bignum/nt/inc/sys/time.h:12:19: error: field 'it_value' has incomplete type struct timeval it_value; /* current value */ ^~~~~~~~ c:/emacs/git/emacs/bignum/lib/gettimeofday.c:64:1: error: conflicting types for 'gettimeofday' gettimeofday (struct timeval *restrict tv, void *restrict tz) ^~~~~~~~~~~~ In file included from c:/emacs/git/emacs/bignum/nt/inc/sys/time.h:4:0, from c:/emacs/git/emacs/bignum/lib/gettimeofday.c:23: c:\mingw\include\sys\time.h:108:29: note: previous declaration of 'gettimeofday' was here int __cdecl __MINGW_NOTHROW gettimeofday ^~~~~~~~~~~~ c:/emacs/git/emacs/bignum/lib/gettimeofday.c: In function 'gettimeofday': c:/emacs/git/emacs/bignum/lib/gettimeofday.c:100:5: error: dereferencing pointer to incomplete type 'struct timeval' tv->tv_sec = microseconds_since_1970 / (ULONGLONG) 1000000; ^~ make[1]: *** [gettimeofday.o] Error 1 make[1]: Leaving directory `/c/emacs/git/emacs/bignum/build/mingw32/lib' make: *** [lib] Error 2 >> > Can you tell what is the following hunk about? >> > >> >> @@ -3414,7 +3473,7 @@ Markers are converted to integers. */) >> >> else >> >> { >> >> eassume (FIXNUMP (number)); >> >> - if (XINT (number) > MOST_POSITIVE_FIXNUM) >> >> + if (XINT (number) > MOST_NEGATIVE_FIXNUM) >> >> XSETINT (number, XINT (number) - 1); >> >> else >> >> { >> >> The updated Fadd1 checks if the old value is MOST_POSITIVE_FIXNUM before >> incrementing, as that would need a bignum result. >> >> This hunk in Fsub1 should check if the old value is MOST_NEGATIVE_FIXNUM >> before decrementing, as that would need a bignum result. > > So the previous code in Fsub1 had a bug? The code on master is fine, but there was a bug in the conversion to bignums. It looks like the code in Fsub1 was copy-pasted from Fadd1 but not all of the differences got fixed up. > >> > Also, this: >> > >> >> +(defun ccl-fixnum (code) >> >> + "Convert a CCL code word to a fixnum value." >> >> + (- (logxor (logand code #x0fffffff) #x08000000) #x08000000)) >> >> The CCL compiled codewords are 28bits, but the CCL implementation >> assumes that the codewords are sign-extended, so that data constants in >> the upper part of the codeword are signed. This function truncates a >> codeword to 28bits, and then sign extends the result to a fixnum. >> >> This ensures that the CCL compiler output is the same on master and >> bignum branches. > > Yes, I know. I was asking for a comment to that effect, so that > others won't wonder what this is about. I'll update the patch to add a comment. AndyM