From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Mon, 29 Nov 2021 08:16:25 -0800 Message-ID: <8635nfkkdi.fsf@pobox.com> References: <86tuhvmtpl.fsf@runbox.com> <87a6jd5891.fsf@gnus.org> <86mtmykxro.fsf@runbox.com> <87y26hz24c.fsf@gnus.org> <86bl3blcgm.fsf@runbox.com> <87wnlya9sj.fsf@gnus.org> <86wnlbmooj.fsf@runbox.com> <87fsry7qdy.fsf@gnus.org> <87bl2m7q9g.fsf@gnus.org> <86zgq5kn9y.fsf@runbox.com> <87ilws7d7e.fsf@gnus.org> <87pmqxlsob.fsf@gnus.org> <86pmqwkw1r.fsf@pobox.com> <86mtlylqm6.fsf@pobox.com> <86h7c4l1wa.fsf@pobox.com> <868rxdldoo.fsf@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17189"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.15; emacs 28.0.50 Cc: gazally@runbox.com, Lars Ingebrigtsen , 51037@debbugs.gnu.org To: Filipp Gunbin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 29 17:17:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrjL8-0004KN-2c for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Nov 2021 17:17:14 +0100 Original-Received: from localhost ([::1]:47756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrjL6-0004l6-DI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Nov 2021 11:17:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrjKy-0004ky-C8 for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2021 11:17:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrjKx-00028E-3B for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2021 11:17:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrjKw-0007rt-H9 for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2021 11:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Nov 2021 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51037-submit@debbugs.gnu.org id=B51037.163820261429797 (code B ref 51037); Mon, 29 Nov 2021 16:17:02 +0000 Original-Received: (at 51037) by debbugs.gnu.org; 29 Nov 2021 16:16:54 +0000 Original-Received: from localhost ([127.0.0.1]:39107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrjKn-0007kG-GO for submit@debbugs.gnu.org; Mon, 29 Nov 2021 11:16:53 -0500 Original-Received: from transit01.runbox.com ([91.220.196.211]:58236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrjKl-0007dv-JN for 51037@debbugs.gnu.org; Mon, 29 Nov 2021 11:16:52 -0500 Original-Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by transit01.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1mrjKe-008tJ4-Pn; Mon, 29 Nov 2021 17:16:44 +0100 Original-Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1mrjKd-00073k-PC; Mon, 29 Nov 2021 17:16:43 +0100 Original-Received: by submission01.runbox with esmtpsa [Authenticated ID (942723)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1mrjKP-0002IR-Fx; Mon, 29 Nov 2021 17:16:29 +0100 In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221035 Archived-At: > On 24/11/2021 08:29 -0800, Michael wrote: > >>>> So, we could do either of: >>>> >>>> 1. As Filipp suggests, just change the contract for >>>> `ert-batch-backtrace-line-length' to: if set to nil, you >>>> get >>>> full stack traces, period. >>>> >>>> 2. change `cl-print-to-string-with-limit' to respect the >>>> existing values of `print-length' & `print-level' when >>>> `limit' is nil. Note that the only caller (in Emacs) of >>>> this >>>> function is the backtrace package. >>>> >>>> I vote for option 2. What say you all? >>> >>> I think the right way is 1 (which I already installed) because >>> then, as >>> the result of your patch, we get the ability to override >>> backtrace-line-length with ert-batch-backtrace-line-length, >>> and >>> nothing >>> more. >>> >>> Changing the semantics of backtrace-line-length should be done >>> (if done) >>> in a separate issue, IMO. >>> >>> Personally, I like that LIMIT in cl-print-to-string-with-limit >>> is "hard >>> override". >> >> *shrugs* OK... so can we close this issue? > > But it's closed already? So it is-- thanks. -- Michael