From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#59888: [PATCH] Add 'grep-heading-mode' Date: Fri, 09 Dec 2022 09:23:46 +0200 Organization: LINKOV.NET Message-ID: <86359pm55x.fsf@mail.linkov.net> References: <87v8mndrla.fsf@gmail.com> <87ilime025.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30118"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Kangas , 59888@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 09 08:44:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3Y3K-0007Za-Ra for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Dec 2022 08:44:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3Y3C-0002TO-7B; Fri, 09 Dec 2022 02:44:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3Y3A-0002Rw-9G for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 02:44:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3Y3A-0004q5-0F for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 02:44:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3Y39-0004Av-T7 for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 02:44:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Dec 2022 07:44:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59888-submit@debbugs.gnu.org id=B59888.167057181715961 (code B ref 59888); Fri, 09 Dec 2022 07:44:03 +0000 Original-Received: (at 59888) by debbugs.gnu.org; 9 Dec 2022 07:43:37 +0000 Original-Received: from localhost ([127.0.0.1]:34352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Y2j-00049L-DS for submit@debbugs.gnu.org; Fri, 09 Dec 2022 02:43:37 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:32797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Y2h-000490-HF for 59888@debbugs.gnu.org; Fri, 09 Dec 2022 02:43:36 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 1549724000E; Fri, 9 Dec 2022 07:43:27 +0000 (UTC) In-Reply-To: <87ilime025.fsf@gmail.com> (Augusto Stoffel's message of "Thu, 08 Dec 2022 10:06:58 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250360 Archived-At: >> How about making this into a defcustom instead of a minor mode? >> >> I'm thinking that something like >> >> (setopt grep-use-headings t) >> >> is a slightly simpler interface to use than >> >> (add-hook 'grep-mode-hook 'grep-heading-mode) >> >> I also think the former plays a bit better with customize. > > This is at the same time less customizable in the sense that something > like > > (add-hook 'grep-mode-hook > (lambda () (when condition) (setq grep-use-headings t))) > > will not work (I think), while conditionally activating a minor mode > certainly works. But I'm open to both approaches. Why not? (setq-local grep-use-headings t) definitely should do the right thing.