From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#67310: [PATCH] Include the project--list as history when prompting for a project Date: Mon, 27 Nov 2023 19:10:22 +0200 Organization: LINKOV.NET Message-ID: <8634wr6s1t.fsf@mail.linkov.net> References: <421e3ea8-d150-566e-f645-cbf1ccbcba61@gutov.dev> <81b6ed58-3fdc-3b5a-41a9-84d66475d5f1@gutov.dev> <5c3eb6a1-38da-8af4-419a-e0567b163e3a@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5776"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 67310@debbugs.gnu.org, Dmitry Gutov , eliz@gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 27 18:12:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r7f9Z-0001Kx-JC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Nov 2023 18:12:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7f9Q-00087B-Gv; Mon, 27 Nov 2023 12:12:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7f9I-0007on-56 for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2023 12:11:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7f9H-0005NW-NT for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2023 12:11:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r7f9N-0005nh-U1 for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2023 12:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Nov 2023 17:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67310 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67310-submit@debbugs.gnu.org id=B67310.170110510922278 (code B ref 67310); Mon, 27 Nov 2023 17:12:01 +0000 Original-Received: (at 67310) by debbugs.gnu.org; 27 Nov 2023 17:11:49 +0000 Original-Received: from localhost ([127.0.0.1]:44672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7f9B-0005nG-5x for submit@debbugs.gnu.org; Mon, 27 Nov 2023 12:11:49 -0500 Original-Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]:51715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7f98-0005n0-TX for 67310@debbugs.gnu.org; Mon, 27 Nov 2023 12:11:47 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 9AF1DFF817; Mon, 27 Nov 2023 17:11:32 +0000 (UTC) In-Reply-To: (Spencer Baugh's message of "Fri, 24 Nov 2023 10:50:43 -0500") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275140 Archived-At: > + ;; Iterate in reverse order so project--name-history is in > + ;; the correct order. > + (dolist (dir (reverse (project-known-project-roots))) > ;; we filter out directories that no longer map to a project, > ;; since they don't have a clean project-name. > - (if-let (proj (project--find-in-directory dir)) > - (push (cons (project-name proj) proj) ret))) > + (when-let (proj (project--find-in-directory dir)) > + (let ((name (project-name proj))) > + (push name project--name-history) > + (push (cons name proj) ret)))) This change broke the order of 'C-x p p M-n M-n ...', so I pushed this fix: diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index f7f057396e1..a81bb63fba4 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1808,7 +1808,7 @@ project-prompt-project-name (name (project-name proj))) (push name project--name-history) (push (cons name proj) ret))) - ret)) + (reverse ret))) ;; XXX: Just using this for the category (for the substring ;; completion style). (table (project--file-completion-table