From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68671: 30.0.50; C-x 8 e s RET persistently breaks C-x 8 e r Date: Sat, 27 Jan 2024 15:53:57 +0200 Message-ID: <8634ui991m.fsf@gnu.org> References: <86cytn820u.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23626"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68671-done@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 27 14:55:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTj9g-0005wL-Vw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Jan 2024 14:55:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTj97-0004hO-AH; Sat, 27 Jan 2024 08:54:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTj95-0004gi-NU for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 08:54:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTj95-000261-FR for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 08:54:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rTj9C-0000gc-CY for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 08:55:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jan 2024 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68671 X-GNU-PR-Package: emacs Mail-Followup-To: 68671@debbugs.gnu.org, eliz@gnu.org, me@eshelyaron.com Original-Received: via spool by 68671-done@debbugs.gnu.org id=D68671.17063636562555 (code D ref 68671); Sat, 27 Jan 2024 13:55:02 +0000 Original-Received: (at 68671-done) by debbugs.gnu.org; 27 Jan 2024 13:54:16 +0000 Original-Received: from localhost ([127.0.0.1]:53648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTj8R-0000f9-SQ for submit@debbugs.gnu.org; Sat, 27 Jan 2024 08:54:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTj8N-0000en-LO for 68671-done@debbugs.gnu.org; Sat, 27 Jan 2024 08:54:14 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTj8A-00020k-WA; Sat, 27 Jan 2024 08:53:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RpTJ9IIAFOghkb0D16vzXJZ5CRM/uCxYRB1/4aRvgew=; b=gAeAe2tQsGJ5 b8p17Sf/mOt9+2HGF3mP+ASe64MbBi8WMh9QpPyzeCJI+eCP/yu3Fh2TbCGTzrTYX2Cuf/jp4PCpE Y7aHPKx0NLeHSSOP5z/Bsa4DtMhxSQV8ZWy+xrR21cyV26y4zfVdKv0X1jHa2Y2wMDDVRPHfIvHQQ 7p6EaLYf6jE9jRNzI83I/X61MbNuoU4y84hEyFHPqGWUF8cC7bWmQucNLln4to3EDxa4LCpszVBGh tpXbTHNpxEjL62qukd+heZzT762CpDlxSsyrmxwkoCObYtluTrxqoh0rxWiYSpF6qEBOvVt0nQei8 3vu308PiPn1m+dd7yAFvxg==; In-Reply-To: (message from Eshel Yaron on Sat, 27 Jan 2024 14:10:15 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279002 Archived-At: > From: Eshel Yaron > Cc: 68671@debbugs.gnu.org > Date: Sat, 27 Jan 2024 14:10:15 +0100 > > Eli Zaretskii writes: > > >> Date: Tue, 23 Jan 2024 11:59:41 +0100 > >> From: Eshel Yaron via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> > >> 1. emacs -Q > >> 2. C-x 8 e s RET > >> [ i.e. invoke `emoji-search` and exit with an empty minibuffer ] > >> 3. Observe error "Wrong type argument: char-or-string-p, nil". This > >> error message could be more friendly, but that's not the issue here. > >> 4. C-x 8 e r > >> 5. Observe error "Wrong type argument: stringp, nil". That's the issue. > >> > >> What happens is that C-x 8 e s RET adds `nil` to the value of > >> `emoji--recent`, which breaks subsequent C-x 8 e r (`emoji-recent`). > >> This is extra troublesome because `emoji--recent` is used as a > >> multisession variable, so simply restarting Emacs doesn't help. > >> > >> I see this also with Emacs 29.2, FWIW. > > > > Thanks. Patches for fixing this will be most welcome. > > I'm attaching such a patch below. This provides better feedback when > you exit the `C-x 8 e s` minibuffer with an empty input, and avoids > adding `nil` to `emoji--recent` by bailing beforehand. Thanks, installed on both emacs-29 and master branches, and closing the bug.