From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) : Set to 64. Date: Thu, 08 Feb 2024 09:23:41 +0200 Message-ID: <8634u3xvuq.fsf@gnu.org> References: <170727415485.32408.11264518274307262467@vcs2.savannah.gnu.org> <20240207024915.38686C0EFEC@vcs2.savannah.gnu.org> <87plx74u0i.fsf@yahoo.com> <0e8b1009-1491-2fb7-9efc-c415ed66d334@gmail.com> <87a5ob4ok3.fsf@yahoo.com> <62ce63d3-76ce-b511-b2bf-27eb526bb711@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32400"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, stefankangas@gmail.com, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 08 08:24:13 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rXylZ-0008Gc-Dw for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Feb 2024 08:24:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXyl8-0002gH-Dj; Thu, 08 Feb 2024 02:23:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXyl6-0002g2-8W for emacs-devel@gnu.org; Thu, 08 Feb 2024 02:23:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXyl5-0004Qx-V0; Thu, 08 Feb 2024 02:23:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=itXdOBjcsD0eZjoMm4D8rvtVjXDa5CnOI797L7KB9Gw=; b=InO5//FyEvYc GkmazXbzSvsWMy5T40T+y5UGMISz8IckgTkBf+exlC+RoPcqyR4tUGhAdYJA4mJ3KjSQZEuY6WmL+ lRXcteaeiRBmDUCcVnCvqqYJ0ywOAup0u1i7VkO8b079Wl/BHtPiLX72XoOsZMpezs0UcIxq2dCcj oQ6EQN9YZg3ihBFbvEudjEsjZPWZ1L2yRuSJ/9C7Z7SMmDOr3307/oJxSU33tp4YuhZsBKxckKFA6 6DQXrTtLAO+7gGKxliCjcZWSm6tAw90TlJP47E/ZRKuoCqM4IWARY3+g4EDK0qrfqdyTnGZ2sTL3L ZyxdVbxZ3zTAZ/7UGUz6+w==; In-Reply-To: <62ce63d3-76ce-b511-b2bf-27eb526bb711@gmail.com> (message from Jim Porter on Wed, 7 Feb 2024 22:13:01 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316023 Archived-At: > Date: Wed, 7 Feb 2024 22:13:01 -0800 > Cc: Stefan Kangas , emacs-devel@gnu.org, eliz@gnu.org > From: Jim Porter > > On 2/7/2024 7:34 PM, Po Lu wrote: > > Jim Porter writes: > > > >> I don't have a terribly strong opinion here of what number to use, but > >> we should at least resolve the inconsistencies in CONTRIBUTE, > >> .dir-locals.el, and build-aux/git-hooks/commit-msg. > > > > commit-msg is fine as-is, but CONTRIBUTE should be fixed. I'm not sure I understand what needs to be fixed in CONTRIBUTE. If that's fallout of the recent change of fill-column, then I'd expect the author of that change to adjust CONTRIBUTE as needed. > I think I understand now. I find the CONTRIBUTE explanation rather > confusing to be honest, since it introduces ChangeLog files, mentions > ChangeLog entries in that context (which I interpret as "one commit > message -> one ChangeLog entry"), and then later talks about ChangeLog > entries again, but in the context of the commit message (where I > interpret it to mean "one ChangeLog entry = one file/function changed"). > Only after reading this a few times in detail did I notice this distinction. Please try to tell in more detail what confused you. I don't want to make any significant change in CONTRIBUTE, since the current text is the result of many people reading it and commenting on its text. So I'd prefer to make the minimal required changes, not rewrite whole passages anew. AFAICS, the current text clearly explains what it means by "ChangeLog entries" that are part of the commit log messages. All of this text is under the "Commit messages" heading, so it is all about commit log messages, not about ChangeLog files (which we no longer maintain by hand as part of documenting changes we install). So I don't quite see why you got confused by the text there; please elaborate. > No worries if this doesn't get merged, or if people change my wording. I > just thought it would be helpful to show an example of what I'd find > clearer. I'd prefer if you explained what is not clear in the current text. Thanks.