From: Eli Zaretskii <eliz@gnu.org>
To: gerd.moellmann@gmail.com
Cc: dmitry@gutov.dev, monnier@iro.umontreal.ca, 70432-done@debbugs.gnu.org
Subject: bug#70432: 30.0.50; C-h for help not working with C-h k
Date: Sat, 20 Apr 2024 12:13:50 +0300 [thread overview]
Message-ID: <8634rg9z1t.fsf@gnu.org> (raw)
In-Reply-To: <867cgueoth.fsf@gnu.org> (message from Eli Zaretskii on Thu, 18 Apr 2024 17:19:06 +0300)
> Cc: gerd.moellmann@gmail.com, dmitry@gutov.dev, 70432@debbugs.gnu.org
> Date: Thu, 18 Apr 2024 17:19:06 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: Stefan Monnier <monnier@iro.umontreal.ca>
> > Cc: Gerd Möllmann <gerd.moellmann@gmail.com>, Dmitry
> > Gutov
> > <dmitry@gutov.dev>, 70432@debbugs.gnu.org
> > Date: Thu, 18 Apr 2024 09:51:54 -0400
> >
> > > Dmitry and Stefan, any better ideas?
> > >
> > > diff --git a/lisp/help.el b/lisp/help.el
> > > index d4e39f0..e6117ec 100644
> > > --- a/lisp/help.el
> > > +++ b/lisp/help.el
> > > @@ -1049,6 +1049,9 @@ help--read-key-sequence
> > > (let ((enable-disabled-menus-and-buttons t)
> > > (cursor-in-echo-area t)
> > > (side-event nil)
> > > + ;; Showing the list of key sequences makes no sense when they
> > > + ;; asked about a key sequence.
> > > + (echo-keystrokes-help nil)
> > > saved-yank-menu)
> > > (unwind-protect
> > > (let (last-modifiers key-list)
> >
> > Loos OK to me, tho maybe it should be the other way around: we should
> > bind it to non-nil around those places where we know it makes sense?
>
> It's a user option, so I don't think that would be a good idea.
I've now installed a fix for this on master, and I'm therefore closing
this bug.
prev parent reply other threads:[~2024-04-20 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 7:36 bug#70432: 30.0.50; C-h for help not working with C-h k Gerd Möllmann
2024-04-18 12:02 ` Eli Zaretskii
2024-04-18 13:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-18 14:19 ` Eli Zaretskii
2024-04-20 9:13 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634rg9z1t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70432-done@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=gerd.moellmann@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.