From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70593: 30.0.50; Dired: buffers of renamed dirs are broken Date: Sun, 19 May 2024 08:32:55 +0300 Message-ID: <8634qecqns.fsf@gnu.org> References: <87a5lguygb.fsf@web.de> <861q6syxzb.fsf@gnu.org> <87a5kmyhmb.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25628"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70593@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 19 07:36:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s8ZDO-0006Vx-Gn for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 May 2024 07:36:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s8ZDH-0007Da-5j; Sun, 19 May 2024 01:36:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8ZDD-0007DC-VU for bug-gnu-emacs@gnu.org; Sun, 19 May 2024 01:36:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s8ZDC-0005DL-Mm for bug-gnu-emacs@gnu.org; Sun, 19 May 2024 01:35:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s8ZDG-0000D9-3T for bug-gnu-emacs@gnu.org; Sun, 19 May 2024 01:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 May 2024 05:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70593 X-GNU-PR-Package: emacs Original-Received: via spool by 70593-submit@debbugs.gnu.org id=B70593.1716096920793 (code B ref 70593); Sun, 19 May 2024 05:36:02 +0000 Original-Received: (at 70593) by debbugs.gnu.org; 19 May 2024 05:35:20 +0000 Original-Received: from localhost ([127.0.0.1]:35761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8ZCZ-0000Cj-O9 for submit@debbugs.gnu.org; Sun, 19 May 2024 01:35:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8ZCX-0000Cd-VV for 70593@debbugs.gnu.org; Sun, 19 May 2024 01:35:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8ZAH-0004pK-E7; Sun, 19 May 2024 01:32:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=afaBdHAcRzhMyKEdiDzLGSvRP5Hb8i60NHN/KopE+nM=; b=KsWI0yuU2L7S aXQOvi1/Qqni8OTLvYhQkdbmQHgJ4QaLqDA2rNQgEiMkAWTi0FeG1ZcbhP5rFnEUhNKSbVHe5B3KC Qp5G9iHG3Orc8IqPJHWc75f7KKVijvKG79ROSR1OZdVLHxUdJMp6ML2CbkCT+WjEIeHudKSM4kLbp Ope/ePGld8pHUJtLeNmn+nFjiYde+T2j2ObgfAgdvXVfPascVIAE1ae18jcVYqfMG1gf0l/7yzUEB fkrkB3+qO+/5y46AHYsyAkSXFDyul0gTt8wHH9/tKehPMBUd/SGhSkJ4OTob320dSPOokqx/ion1m XL1cnH2eR2QcZED4SND/4A==; In-Reply-To: <87a5kmyhmb.fsf@web.de> (message from Michael Heerdegen on Sat, 18 May 2024 22:45:00 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285400 Archived-At: > From: Michael Heerdegen > Cc: 70593@debbugs.gnu.org > Date: Sat, 18 May 2024 22:45:00 +0200 > > Eli Zaretskii writes: > > > So all we need to do is call expand-file-name on both of them? Or do > > we need also to call file-truename? > > When symlinks are involved it gets really messy. > > For example: here is an additional problem I encountered: > `dired-rename-subdir' sometimes doesn't even handle our buffer because > `dired-fun-in-all-buffers', which is built on `dired-buffers-for-dir', > doesn't consider symlinks at all: For `dired-buffers-for-dir' a buffer > that visits some DIR under a different name is simply not visiting DIR. > > Other problems are: our buffer could visit a file under a now dead link. > The file renamed could have been moved from behind a link to some > completely unrelated place. Our buffer could dired a subdirectory of a > renamed directory (this case is currently completely ignored). > > I feel a bit lost. Fixing this would be nice, at least the cases where > this is possible, but it's really complicated and I don't even know the > dired code very well. We could document that renaming a directory that is a symlink is currently not supported, and move on. Someone who is motivated enough could come up with patches to fix that later. Is there some narrower problem you'd like to fix there at this time and know how to do that? If so, feel free to install such a narrower fix. Thanks.