From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Date: Sat, 15 Jun 2024 10:56:36 +0300 Message-ID: <8634pewsej.fsf@gnu.org> References: <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6126"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71209@debbugs.gnu.org, dev@rjt.dev To: noah.v.peart@gmail.com, Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 15 09:57:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIOHe-0001Mw-LL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jun 2024 09:57:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIOHX-0003jj-1m; Sat, 15 Jun 2024 03:57:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIOHV-0003jG-DX for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2024 03:57:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sIOHV-000813-5l for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2024 03:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sIOHV-00031c-Kj for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2024 03:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jun 2024 07:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71209-submit@debbugs.gnu.org id=B71209.171843821911614 (code B ref 71209); Sat, 15 Jun 2024 07:57:01 +0000 Original-Received: (at 71209) by debbugs.gnu.org; 15 Jun 2024 07:56:59 +0000 Original-Received: from localhost ([127.0.0.1]:51670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIOHS-00031G-Jq for submit@debbugs.gnu.org; Sat, 15 Jun 2024 03:56:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIOHQ-00030q-1t for 71209@debbugs.gnu.org; Sat, 15 Jun 2024 03:56:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIOHK-00080B-4O; Sat, 15 Jun 2024 03:56:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=D+5C+tk8RUI29NUAUU/HFg9Qlbtk4dC05laz6IDRu4M=; b=l7E8bZkVnbXoOQ+WR3Jd KHwJVVEO9GVvaUGUf5aFH9Rc5bhqEwicX//KhGn+BjdKvHRbVsOrc/TwuuRspTuLgonUMHPy1TQhl JbZGhfZnbr43IeM9R5JRj+C4QE9qdHb0BnxAnmYRfVNW5fpCCMnQtKXcHIM0hwCbhEWXlBSk9KIsi Yxn1vKO4/wJ2lHfPZgv0kzfyjSp85SKROWVe3EzeJEAfpVlRqa4fmBsVS3uWCKjJ7RQfx+d0C3cee OxU2ev7iZeWZMCRXRXhAhfOiF6QgEqbcAGuEj4N+iEjEVqCL1PTLiRo/feV8TT0tngoWz01JioLj7 WAyzQguw7Yk9Nw==; In-Reply-To: <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@gutov.dev> (message from Dmitry Gutov on Sat, 1 Jun 2024 17:13:57 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287255 Archived-At: Ping! Noah, would you please answer Dmitry? > Cc: 71209@debbugs.gnu.org > Date: Sat, 1 Jun 2024 17:13:57 +0300 > From: Dmitry Gutov > > On 01/06/2024 04:42, Noah Peart wrote: > > > > I've been using these for c++, I think they are still missing > > > >     ;; for (auto x: ...) > >     (for_range_loop > >      declarator: (identifier) @font-lock-variable-name-face) > >     ;; auto& x > >     (reference_declarator > >      (identifier) @font-lock-variable-name-face) > >     ;; auto[&] [x, y] > >     (structured_binding_declarator > >      _ [(identifier)] @font-lock-variable-name-face) > > > > I suppose most people keep the default font-locking for variable-name > > and variable-use, so these missing rules go unnoticed. > > Do you want to submit a full patch with these as well? > > > >