From: Eli Zaretskii <eliz@gnu.org>
To: Matthew Bauer <mjbauer95@gmail.com>
Cc: 71844@debbugs.gnu.org
Subject: bug#71844: [PATCH] 29.1; "cucumber" in compilation-error-regexp-alist-alist is too aggressive
Date: Sun, 30 Jun 2024 08:05:54 +0300 [thread overview]
Message-ID: <8634ovhvf1.fsf@gnu.org> (raw)
In-Reply-To: <m2le2n1q3q.fsf@gmail.com> (message from Matthew Bauer on Sat, 29 Jun 2024 14:55:05 -0500)
> From: Matthew Bauer <mjbauer95@gmail.com>
> Date: Sat, 29 Jun 2024 14:55:05 -0500
>
> I believe this regex for cucumber is not precise enough. Specifically,
> it was picking up this indentation in an error message from GHC:
>
> Main.hs:195:1: error: [GHC-44432]
> The type signature for ‘apathway’ lacks an accompanying binding
> Suggested fix:
> Perhaps use one of these:
> ‘foo’ (Defined at Main.hs:196:1),
> ‘foo’ (Defined at Main.hs:216:1)
>
> It picked up this as being error messages which I believe it shouldn’t have:
>
> ‘foo’ (Defined at Main.hs:216
> ‘foo’ (Defined at Main.hs:216
Why not? don't you want to be able to visit the definitions to examine
whether they are the right fix?
More generally, compilation-mode doesn't (yet) support the "fix
suggestion" features offered by some of the modern compilers. IMO, we
should address this kind of situations in a general framework of
supporting fix suggestions, not just by ad-hoc changes in the regexps
that recognize error messages. Patches welcome.
prev parent reply other threads:[~2024-06-30 5:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 19:55 bug#71844: [PATCH] 29.1; "cucumber" in compilation-error-regexp-alist-alist is too aggressive Matthew Bauer
2024-06-30 5:05 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634ovhvf1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71844@debbugs.gnu.org \
--cc=mjbauer95@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.