From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: dangling markers Date: Tue, 02 Jul 2024 14:25:51 +0300 Message-ID: <8634osdohs.fsf@gnu.org> References: <87v81u85hv.fsf@localhost> <1osQTI7Swoo72EJbCzzi4zqVXuC5hSlYEXwLtnal8_pyYL7oRCNSJg20XgBRjffZ344Wj7lwFDc9JSMsQ-3su6uXQ8hYSfYleRn-4GRrykI=@protonmail.com> <868qyldjqi.fsf@gnu.org> <_nyaStUr9UjwGJZ-bqaGNyxgCMuh-bglMdWw2rpGNja9pdNct6lfF2QXthIQFfjn2-n-T3R4WCuHMLdmIuoRzzAfuHrw0Q1rq3V-5oFLzDE=@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1397"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, yantar92@posteo.net, monnier@iro.umontreal.ca, emacs-devel@gnu.org, eller.helmut@gmail.com To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 02 13:26:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sObeP-000Ae0-22 for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Jul 2024 13:26:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sObe6-0003is-V0; Tue, 02 Jul 2024 07:26:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sObe5-0003i2-AQ for emacs-devel@gnu.org; Tue, 02 Jul 2024 07:26:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sObe4-0002X6-1R; Tue, 02 Jul 2024 07:26:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YFNjFi3xgUXFa4h1ub8agJgUzypDmFcImeQMYex1JwY=; b=AGF4W0ID4ZEH s0zbDqkXqzlz0hmD847yPRCnTH3qYfs/tkN/V0VEx1dD3Lw9A80Gtl7qbHWtgMhyMOKmVx+kgFoK0 GBoqgGt0crIwG52ld4Joj6IaaM4LQhbkhESZfAaeSS14P4M0XUTD042Uide8Ao0hj5uXmJ6jZunnn j5NM/fC7vfK9siPVVGVUWH5eEQ2LIVGTdrw1VIrguA2q6M3LEUJ025JWrQs3+TbD/O7RiEFjmxIWt vQKGUmTYIf15f36QVYXiRr8Lo7/O4A3k16bxVT05y36oGie5SchmX0Ijpni+m0MdvJB2KXidIVINy hkqUy1fmhICwJtSHRG9XcQ==; In-Reply-To: <_nyaStUr9UjwGJZ-bqaGNyxgCMuh-bglMdWw2rpGNja9pdNct6lfF2QXthIQFfjn2-n-T3R4WCuHMLdmIuoRzzAfuHrw0Q1rq3V-5oFLzDE=@protonmail.com> (message from Pip Cet on Mon, 01 Jul 2024 21:08:07 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321125 Archived-At: > Date: Mon, 01 Jul 2024 21:08:07 +0000 > From: Pip Cet > Cc: gerd.moellmann@gmail.com, yantar92@posteo.net, monnier@iro.umontreal.ca, emacs-devel@gnu.org, eller.helmut@gmail.com > > Sorry, it took me a while to reproduce this because the default build worked fine, I had to --enable-checking to get something like your error, though in my case it was clearly the set_weak_hash_hash_value call that was to blame. > > I incorrectly assumed sxhash, Fsxhash, and the hash value in an equal-based hash table were all the same number; in reality, sxhash is 32 bits on a 32-bit system, 64 bits on a 64-bit system, Fsxhash is 30 bits on a 32-bit system, 62 bits on a 64-bit system, and the hash value is 32 bits on all systems. > > Long story short, would you be able to try this patch and see whether you get a clean dump? I do here... Yes, this fixes the build, thanks.