From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: Crash while completing symbol with corfu Date: Wed, 03 Jul 2024 18:44:03 +0300 Message-ID: <8634oqbhvg.fsf@gnu.org> References: <87y16lbh10.fsf@localhost> <86v81pduw3.fsf@gnu.org> <87sewt87ni.fsf@localhost> <4aK6qyh6gPCldT2u0rLYOuIk7a5Coo8yNf71tkkBOlUh0yk3nU8yjRAZygm9rIzK3kOcyq_IAatIKS2buH7tgA2PwHIOgLTiqQRSoypoOfY=@protonmail.com> <871q4cja54.fsf@localhost> <871q4b6d2v.fsf@localhost> <867ce2bie8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20710"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, gerd.moellmann@gmail.com, emacs-devel@gnu.org, eller.helmut@gmail.com To: pipcet@protonmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 03 17:44:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sP29w-00058Z-5p for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jul 2024 17:44:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sP29P-0005q3-Ox; Wed, 03 Jul 2024 11:44:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sP29N-0005pl-SU for emacs-devel@gnu.org; Wed, 03 Jul 2024 11:44:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sP29N-0006tg-Ec; Wed, 03 Jul 2024 11:44:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tvl0mEnPjCZFHjzLKVF+nFpRryvbV7rQM/g5EX3lNU8=; b=hXM8ghqkwSNlI/jndLNP VHpPiv3KLI0URYqMtCGGYf1qmpHAHqgNr61Ijatz0xVlqUA/AU7uyzdsfwgBlEL7QB4Eok9Nig3Ky PqzLQl+726eG5wizDUeL+sFnieb5RvhJISoROM8rz+axZOilTplv0YCoYEKUsOJ8otK/CzPnsT/yR C9ts3X47RUxKe0THOOg8J2fSnpEzjtPg8gCYI4sKdbsNnniB1AjArh4CgrNXDjW2J34gwTgkFtJg3 taMLiZjpgYzWtKfku2jB2db65hwntoNCcUMa/uKh9d5CRuzJTMw53/nrCyXM6NNfVTlATTLOWcFiQ AU9OjlskOPSAQg==; In-Reply-To: <867ce2bie8.fsf@gnu.org> (message from Eli Zaretskii on Wed, 03 Jul 2024 18:32:47 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321265 Archived-At: > Date: Wed, 03 Jul 2024 18:32:47 +0300 > From: Eli Zaretskii > Cc: yantar92@posteo.net, gerd.moellmann@gmail.com, > emacs-devel@gnu.org, eller.helmut@gmail.com > > > Date: Wed, 03 Jul 2024 14:19:02 +0000 > > From: Pip Cet > > Cc: Eli Zaretskii , Gerd Möllmann , emacs-devel@gnu.org, eller.helmut@gmail.com > > > > > No immediate crashes now. > > > I will keep this session running, with your patches installed. > > > > Thanks! Here's what I'm testing now, FWIW. > > > > Eli, is this sufficiently isolated from the non-MPS case? We use some trivial wrapper macros which become non-trivial in the MPS case, and we always use a slightly more verbose glib function to register handlers (and, in the MPS case, a cleanup handler). > > I think it's okay, but I'd prefer inline functions instead of macros > for glib_user_data and get_glib_user_data. Or maybe just make then UPPER-CASE named, so that it's clear they are macros.