From: Eli Zaretskii <eliz@gnu.org>
To: pipcet@protonmail.com
Cc: yantar92@posteo.net, gerd.moellmann@gmail.com,
emacs-devel@gnu.org, eller.helmut@gmail.com
Subject: Re: MPS: Crash while completing symbol with corfu
Date: Wed, 03 Jul 2024 18:44:03 +0300 [thread overview]
Message-ID: <8634oqbhvg.fsf@gnu.org> (raw)
In-Reply-To: <867ce2bie8.fsf@gnu.org> (message from Eli Zaretskii on Wed, 03 Jul 2024 18:32:47 +0300)
> Date: Wed, 03 Jul 2024 18:32:47 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: yantar92@posteo.net, gerd.moellmann@gmail.com,
> emacs-devel@gnu.org, eller.helmut@gmail.com
>
> > Date: Wed, 03 Jul 2024 14:19:02 +0000
> > From: Pip Cet <pipcet@protonmail.com>
> > Cc: Eli Zaretskii <eliz@gnu.org>, Gerd Möllmann <gerd.moellmann@gmail.com>, emacs-devel@gnu.org, eller.helmut@gmail.com
> >
> > > No immediate crashes now.
> > > I will keep this session running, with your patches installed.
> >
> > Thanks! Here's what I'm testing now, FWIW.
> >
> > Eli, is this sufficiently isolated from the non-MPS case? We use some trivial wrapper macros which become non-trivial in the MPS case, and we always use a slightly more verbose glib function to register handlers (and, in the MPS case, a cleanup handler).
>
> I think it's okay, but I'd prefer inline functions instead of macros
> for glib_user_data and get_glib_user_data.
Or maybe just make then UPPER-CASE named, so that it's clear they are
macros.
next prev parent reply other threads:[~2024-07-03 15:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 9:25 MPS: Crash while completing symbol with corfu Ihor Radchenko
2024-07-01 14:48 ` Gerd Möllmann
2024-07-01 14:55 ` Eli Zaretskii
2024-07-01 14:58 ` Eli Zaretskii
2024-07-01 15:09 ` Gerd Möllmann
2024-07-01 15:02 ` Gerd Möllmann
2024-07-01 15:16 ` Ihor Radchenko
2024-07-02 0:24 ` Pip Cet
2024-07-02 11:39 ` Ihor Radchenko
2024-07-02 14:19 ` Pip Cet
2024-07-02 15:14 ` Ihor Radchenko
2024-07-03 14:19 ` Pip Cet
2024-07-03 15:32 ` Eli Zaretskii
2024-07-03 15:44 ` Eli Zaretskii [this message]
2024-07-03 18:25 ` Ihor Radchenko
2024-07-03 20:25 ` Pip Cet
2024-07-04 20:46 ` Pip Cet
2024-07-05 5:51 ` Eli Zaretskii
2024-07-05 6:12 ` Pip Cet
2024-07-05 6:29 ` Eli Zaretskii
2024-07-02 12:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634oqbhvg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eller.helmut@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=pipcet@protonmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.