From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71935: split-string-and-unquote mishandles dired-listing-switches with ' Date: Thu, 04 Jul 2024 21:12:01 +0300 Organization: LINKOV.NET Message-ID: <8634opowlq.fsf@mail.linkov.net> References: <86tth5tztt.fsf@mail.linkov.net> <86zfqx8tnn.fsf@gnu.org> <86a5ixqhd4.fsf@mail.linkov.net> <868qyh82is.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18059"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: 71935@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 20:14:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPQyI-0004Zd-8Y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 20:14:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPQy8-00038Y-55; Thu, 04 Jul 2024 14:14:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPQy0-000344-L2 for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:14:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPQy0-0005xU-CW for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:14:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPQy2-00013y-JQ for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 18:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71935 X-GNU-PR-Package: emacs Original-Received: via spool by 71935-submit@debbugs.gnu.org id=B71935.17201167964023 (code B ref 71935); Thu, 04 Jul 2024 18:14:02 +0000 Original-Received: (at 71935) by debbugs.gnu.org; 4 Jul 2024 18:13:16 +0000 Original-Received: from localhost ([127.0.0.1]:42933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPQxI-00012o-3b for submit@debbugs.gnu.org; Thu, 04 Jul 2024 14:13:16 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:40901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPQx1-000123-Gr for 71935@debbugs.gnu.org; Thu, 04 Jul 2024 14:13:14 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 190BE1C0002; Thu, 4 Jul 2024 18:12:49 +0000 (UTC) In-Reply-To: <868qyh82is.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Jul 2024 20:56:11 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288389 Archived-At: >> >> 1. (setopt dired-listing-switches "-al --block-size='1") >> >> 2. C-x d /tmp/* >> >> This part of insert-directory is used only in case of 1-2 above, >> i.e. for wildcard '/tmp/*'. In this case the value of 'switches' >> is "--dired -N -al --block-size='1", and 'shell-quote-argument' >> returns "--dired\\ -N\\ -al\\ --block-size\\=\\'1" that fails. > > I meant to call shell-quote-argument on each option, before they are > concatenated. But switches are never unconcatenated in a list, they come from the string: (setopt dired-listing-switches "-al --block-size='1") >> For the non-wildcard case of 3-4 above, this doesn't help either. >> Using (mapcar 'shell-quote-argument (split-string-and-unquote switches)) >> on ("--dired" "-N" "-al" "--block-size=\\'1") returns >> ("--dired" "-N" "-al" "--block-size\\=\\\\\\'1") that fails with >> >> /bin/ls: unrecognized option '--block-size\=\\\'1' > > Why did you use "--block-size=\\'1"? My idea is that the quoting > should not come from the user. If the wildcard case above could be fixed, then there is no need to use "--block-size=\\'1".