From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command Date: Thu, 25 Jul 2024 21:08:42 +0300 Organization: LINKOV.NET Message-ID: <8634nxjv0l.fsf@mail.linkov.net> References: <87r0bsn0ok.fsf@gmail.com> <86le1xkh8w.fsf@mail.linkov.net> <87r0bpu6tn.fsf@gmail.com> <86ttggr4u5.fsf@mail.linkov.net> <87ed7k4fwd.fsf@web.de> <868qxsyq0o.fsf@mail.linkov.net> <87a5i61ztv.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15746"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: 72147@debbugs.gnu.org, Visuwesh To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 25 20:23:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sX37g-00041K-HA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jul 2024 20:23:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sX37E-0006jP-6Y; Thu, 25 Jul 2024 14:23:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sX379-0006ia-T1 for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 14:22:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sX379-0002k8-76 for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 14:22:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sX37F-0003Tl-KH for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 14:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2024 18:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72147 X-GNU-PR-Package: emacs Original-Received: via spool by 72147-submit@debbugs.gnu.org id=B72147.172193175613323 (code B ref 72147); Thu, 25 Jul 2024 18:23:01 +0000 Original-Received: (at 72147) by debbugs.gnu.org; 25 Jul 2024 18:22:36 +0000 Original-Received: from localhost ([127.0.0.1]:37743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX36q-0003Sp-Fe for submit@debbugs.gnu.org; Thu, 25 Jul 2024 14:22:36 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:45777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX36o-0003Sa-Cz for 72147@debbugs.gnu.org; Thu, 25 Jul 2024 14:22:35 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 2EAB1240003; Thu, 25 Jul 2024 18:22:17 +0000 (UTC) In-Reply-To: <87a5i61ztv.fsf@web.de> (Michael Heerdegen's message of "Wed, 24 Jul 2024 19:09:48 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289328 Archived-At: >> >> Thanks for the patch, now pushed to master. >> > >> > Wouldn't it be better to add a new optional argument NO-HIGHLIGHT to >> > `query-replace-read-args', for stylistic reasons? >> >> It's not clear how such arg should be combined with >> `query-replace-lazy-highlight' in `query-replace-read-args': >> >> (defun query-replace-read-args (prompt regexp-flag &optional noerror no-highlight) >> ... >> (from (minibuffer-with-setup-hook >> (minibuffer-lazy-highlight-setup >> :highlight query-replace-lazy-highlight >> >> with `and'? With `or'? With `xor'? >> `(and query-replace-lazy-highlight (not no-highlight))'? > > The installed patch binds query-replace-lazy-highlight to nil and > shadows the old binding. This would correspond to > > (and query-replace-lazy-highlight (not no-highlight)) > > which looks reasonable in this case: we just an argument to inhibit > highlighting. Because we never want highlighting in some cases (like > here). Agreed, let's add a new argument.