From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Date: Sun, 04 Aug 2024 10:52:36 +0300 Message-ID: <8634nku3ln.fsf@gnu.org> References: <6769ff22-14d3-4c6a-b0a2-dd53ec717f15@gutov.dev> <8634pewsej.fsf@gnu.org> <8634oy7s3s.fsf@gnu.org> <86a5iv55ej.fsf@gnu.org> <867cdge6xj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21318"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71209@debbugs.gnu.org, dmitry@gutov.dev, dev@rjt.dev To: noah.v.peart@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 04 09:53:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saW3q-0005PZ-SV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Aug 2024 09:53:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saW3n-0005Aq-9e; Sun, 04 Aug 2024 03:53:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saW3j-0005AN-4E for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 03:53:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saW3h-0002yU-6p for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 03:53:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=t5aBKW/kRpov25HVPS+QhLLiE85rIBP4yVivrRvXRPM=; b=GIofEZ2PY593a7d0mlY4sZeCFyBjBDuwYN/UWZa5Vw7GNryE+p6Gc4wKBAuSy7MiA4n56I4jsin2FmsXeAd8bNtG3WJgTvYmo2NySEb1yJ7CgaZUQj2HEKdRuzxSr7IzI7CQDH3LuyuegHgSYxNGt+gviPDNY62lhZbB9bHTCeN9rLKZ1HzEMqf+irRBvaFf/Emoz5tUnOaAd1fOCuApkIdMX3NnMCle5TVAt6QwPzsBxHdQsibmQCROp6SNqNDDptzyGfmF27l4naHQBnSoOQmXpuJsWdK8Iy76t2PFkKGAUH2CKTbBtt24FfyjhLX6HWCLg2awgZ5N+Ij/HD6Bxw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1saW41-0004u7-V2 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 03:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2024 07:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71209-submit@debbugs.gnu.org id=B71209.172275798718677 (code B ref 71209); Sun, 04 Aug 2024 07:54:01 +0000 Original-Received: (at 71209) by debbugs.gnu.org; 4 Aug 2024 07:53:07 +0000 Original-Received: from localhost ([127.0.0.1]:55369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saW38-0004rA-V7 for submit@debbugs.gnu.org; Sun, 04 Aug 2024 03:53:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saW36-0004qR-Cy for 71209@debbugs.gnu.org; Sun, 04 Aug 2024 03:53:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saW2g-0002sw-5j; Sun, 04 Aug 2024 03:52:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=t5aBKW/kRpov25HVPS+QhLLiE85rIBP4yVivrRvXRPM=; b=Hea6T7ntjzusGgQj8OJl +0jaI/C/H8w7YN6jLqv8GbhSTZlUPagLHHkdy7edO8vys+nLcNxeiY9HldqSk1irGjSK8AB5TV4kP cAsfM2gluDdTflRKRFLh1/ByQOBTZsj4/N1bfIw56jFPZpQ16apt3abPDSA7z6s4dYBMwjkHcrzm1 u7UouYSpeFU2KrQFlEWvfaLowtRVjfh4Ik523aMMyc780uQlrAkDJRbLeSs58A/77ddLEv0YoZCPa nvVdKKmXKzNJVF/Dpvh1jWUytTUFkFaolKD82z3uuErFCqHGhcs3LhgYflA5ZW3wzrQb0hJVMpKKB ZqCoXEyulXncNw==; In-Reply-To: <867cdge6xj.fsf@gnu.org> (message from Eli Zaretskii on Sat, 20 Jul 2024 12:42:00 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289716 Archived-At: Ping! Ping! Ping! Noah, are you there? > Cc: 71209@debbugs.gnu.org, dmitry@gutov.dev, dev@rjt.dev > Date: Sat, 20 Jul 2024 12:42:00 +0300 > From: Eli Zaretskii > > Ping! Ping! Can we please make some progress here? > > > Cc: 71209@debbugs.gnu.org, dmitry@gutov.dev, dev@rjt.dev > > Date: Sat, 06 Jul 2024 10:46:44 +0300 > > From: Eli Zaretskii > > > > Ping! Any progress with this? > > > > > From: Noah Peart > > > Date: Thu, 27 Jun 2024 05:29:21 -0400 > > > Cc: dmitry@gutov.dev, 71209@debbugs.gnu.org, dev@rjt.dev > > > > > > Ah yes, sorry to be slow, I can submit a patch for those settings. I'll take a look today! > > > > > > On Thu, Jun 27, 2024 at 3:38 AM Eli Zaretskii wrote: > > > > > > Ping! Ping! Noah, are you still interested in working on this? > > > > > > > Cc: 71209@debbugs.gnu.org, dev@rjt.dev > > > > Date: Sat, 15 Jun 2024 10:56:36 +0300 > > > > From: Eli Zaretskii > > > > > > > > Ping! Noah, would you please answer Dmitry? > > > > > > > > > Cc: 71209@debbugs.gnu.org > > > > > Date: Sat, 1 Jun 2024 17:13:57 +0300 > > > > > From: Dmitry Gutov > > > > > > > > > > On 01/06/2024 04:42, Noah Peart wrote: > > > > > > > > > > > > I've been using these for c++, I think they are still missing > > > > > > > > > > > > ;; for (auto x: ...) > > > > > > (for_range_loop > > > > > > declarator: (identifier) @font-lock-variable-name-face) > > > > > > ;; auto& x > > > > > > (reference_declarator > > > > > > (identifier) @font-lock-variable-name-face) > > > > > > ;; auto[&] [x, y] > > > > > > (structured_binding_declarator > > > > > > _ [(identifier)] @font-lock-variable-name-face) > > > > > > > > > > > > I suppose most people keep the default font-locking for variable-name > > > > > > and variable-use, so these missing rules go unnoticed. > > > > > > > > > > Do you want to submit a full patch with these as well? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >