From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Date: Thu, 14 Nov 2024 10:26:02 +0200 Message-ID: <8634jukyqt.fsf@gnu.org> References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> <87ldxtn57i.fsf@pub.pink> <86ses1oijv.fsf@gnu.org> <87ikswi0vc.fsf@pub.pink> <86r07jlk3j.fsf@gnu.org> <87y11r87qw.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4412"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74235-done@debbugs.gnu.org To: john muhl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 14 09:27:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tBVC7-0000xh-Ce for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Nov 2024 09:27:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBVC1-0002s5-05; Thu, 14 Nov 2024 03:27:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBVBu-0002rT-QG for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2024 03:27:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBVBu-0001Hr-HJ for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2024 03:27:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=B6oMtMImB7D9wHQeCk/yP9A3+WcKz/XVe8Y6TdCm318=; b=H/5JJMmvmtjHT8bJAO6VUsjsVZKihEdbNe9b625KdyY+hwo+D3ctJrHxdZgqx5QZPo4XlYkH+U7gtA0SKWHh/59rhPcC+hLh9IjUPSBTzOhhxsxTX5xAbOzCn12/9MH+klezBHCm79zCxxs2yprgmb3ZvKPGqISGiNF8hi7Y3uzFxFkmyFKy0LSniV2BUp2baumS3HhTz33S/f9CQzsAHGxDX6u4BlWT0uIql55v2Kuc7duEPzkENTxNHwslx/gdzDMNZ69wfzrk1ZpJI8JBIDCxQ8TlMEBTiWSxXCvn1KDWUVRfyG9nQfeq2YwreeMlr/QPfVaPN732e1TDa4Krpw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tBVBu-0000tQ-CG for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2024 03:27:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Nov 2024 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 74235@debbugs.gnu.org, eliz@gnu.org, jm@pub.pink Original-Received: via spool by 74235-done@debbugs.gnu.org id=D74235.17315727993384 (code D ref 74235); Thu, 14 Nov 2024 08:27:02 +0000 Original-Received: (at 74235-done) by debbugs.gnu.org; 14 Nov 2024 08:26:39 +0000 Original-Received: from localhost ([127.0.0.1]:44917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBVBW-0000sV-Rc for submit@debbugs.gnu.org; Thu, 14 Nov 2024 03:26:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBVBV-0000sH-4p for 74235-done@debbugs.gnu.org; Thu, 14 Nov 2024 03:26:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBVBO-0001GQ-1G; Thu, 14 Nov 2024 03:26:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=B6oMtMImB7D9wHQeCk/yP9A3+WcKz/XVe8Y6TdCm318=; b=HScOfbVXI8mLCVZkK6U0 6xGaF3M/lVr0UFM372LGwmkYc3+VT0s7gs6Iz5NkJl96s4FWKVMrakiYNCtN5sH1b7ULNm83j75XJ Ftuk0Rib4u3PFRs5aH1eNp185Pt4SIb90vQvsRSqSu0IJ65ZBS4EkMSOgxV1JjsIFrwlykoAJclWM keQc4dqXVSMp3vcc90NvLgsV2zxLF1POvI/vgN8Ye38FK2d5k9KfUVFkkZ7COnf0Be7JuDCbMsGpt Pc3lpr2DenJBGuOqvxmDwbTMHggI3fObDciJOud6YO1rBnoudfj+OrPFnRFNxHNYhbXpPpHBGf9OQ FxF0GYVNr85S0g==; In-Reply-To: <87y11r87qw.fsf@pub.pink> (message from john muhl on Sun, 10 Nov 2024 08:48:39 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295313 Archived-At: > From: john muhl > Cc: 74235@debbugs.gnu.org > Date: Sun, 10 Nov 2024 08:48:39 -0600 > > Eli Zaretskii writes: > > >> From: john muhl > >> Cc: 74235@debbugs.gnu.org > >> Date: Sat, 09 Nov 2024 14:54:47 -0600 > >> > >> + (if (or (not lua-ts-inferior-program) > >> + (not (executable-find lua-ts-inferior-program))) > >> + (user-error "You must set `lua-ts-inferior-program' to use this command") > > > > The text of user-error should say something about being unable to find > > the program, not just about the variable being nil, since you use > > executable-find. > > > > Otherwise, LGTM, thanks. > > I guess the executable-find check is redundant anyway since > comint/process will tell you “Searching for program: No such file > or directory, luaz” if you get it wrong. Thanks, installed on the emacs-30 branch, and closing the bug. Btw, I noticed that you are marking with ";" the log entries of changes which should definitely appear in the produced ChangeLog. Is this on purpose, or did you misunderstand the meaning of the semi-colon in the first line of the commit log messages?