From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Sat, 16 Nov 2024 10:43:40 +0200 Message-ID: <8634jrin5v.fsf@gnu.org> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21514"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 16 09:45:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tCEQo-0005KI-PP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Nov 2024 09:45:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tCEQa-0003dW-Jr; Sat, 16 Nov 2024 03:45:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCEQR-0003dF-2J for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2024 03:45:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tCEQQ-0006KR-PZ for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2024 03:45:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=YPWdJ7mWuoRIAlm9Wtb5irOgWINbbtc79KO4tDL067c=; b=lELZ8IAIOsuueKp3qgoSyU5+iDIKxOg96GE/lMQAgzxh5A76Qn+Y93bTSITaOZMMH1t0yvZevm22OVXOU91WbpRWlRXXdDy035TpGbwwalfKbN51mp4tHuyVBOwJMn5l7s7JAJvIBU27T+Q5xtRfntmn8fKQQaDdWevGddZc/6/0tl7ravboAdo9hxaoGvZQp4JZzkMIIg+F8ZhcbgYaRt6cNV3os48OdiViFRrjOrCjlM2jvenzxk0zeOGK3VmPjp2dW0ecbSiXkZpFnnWcrp9y3S3vaF1xYB/uMn3Ci36F7mMRKcd1UzP4nubhaLfJY7wztUpRi3nHjpKkIjcCOQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tCEQQ-0006Co-Fs for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2024 03:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Nov 2024 08:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173174664223752 (code B ref 74361); Sat, 16 Nov 2024 08:45:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 16 Nov 2024 08:44:02 +0000 Original-Received: from localhost ([127.0.0.1]:52040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCEPR-0006Ar-NI for submit@debbugs.gnu.org; Sat, 16 Nov 2024 03:44:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCEPP-0006AN-6Z for 74361@debbugs.gnu.org; Sat, 16 Nov 2024 03:43:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCEPI-0006Be-2I; Sat, 16 Nov 2024 03:43:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YPWdJ7mWuoRIAlm9Wtb5irOgWINbbtc79KO4tDL067c=; b=NAILXczT07L8 sTQu2AsLsUHMKLVEfnzShOqHpJ7wt7Hw/nty2//VGh++KFKE7F39zyVpXX+G7tseL+5+VYXIE/2BC Dmfbj5rASGJ2J9nIj2Yhp6tewLdfcW8eGt0+udIlnUYVdZ8HsN9SfeypYIOFN97qQu2/HcxlOa0gb xJXS/vS3ZBipCXnKEHTdPpK6e/p9o18zZgQKWAQAc1Z4j1pzOC4tSg0NfmLBKVcr7lFWSCc1AdwKE OjSpiX028k8Ro2gW6/C8C7tIDL8r853pgIn3qvyPRyrhiIprhc2AMGNGVXqhmftA6jcsZ0WInsy1h U9zgyWPdbg08J8Gu3EHD6Q==; In-Reply-To: <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> (message from Dmitry Gutov on Fri, 15 Nov 2024 21:10:25 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295435 Archived-At: > Date: Fri, 15 Nov 2024 21:10:25 +0200 > Cc: 74361@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > >> +(defcustom xref-navigation-display-window-action nil > >> + "When non-nil, the display action to use for navigation commands. > > > > This is too general, when taken alone (as in the apropos commands). I > > suggest something like > > > > If non-nil, the `display-buffer' action for showing results of Xref commands. > > > > (The "navigation" part seems misleading, since xref-find-definitions > > is not a navigation command.) > > That's the term I would use both both, but maybe there could be better > wording. If xref-find-definition is not a navigation command, is it a > "search command"? Let me turn the table and ask: which Xref commands will NOT use this action, if we exclude commands like xref-find-definitions-other-window, which specify the window/frame to use? > >> +This does not affect commands that specify the action explicitly, > > > > I guess "...that specify the window to use explicitly" is more > > accurate? > > Or frame. Yes, so "...specify the window/frame to use...".