From: Eli Zaretskii <eliz@gnu.org>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: 74854@debbugs.gnu.org
Subject: bug#74854: [PATCH] Improve menu separator display on ttys slightly
Date: Fri, 13 Dec 2024 18:16:51 +0200 [thread overview]
Message-ID: <8634iry2vg.fsf@gnu.org> (raw)
In-Reply-To: <m2frmrfwlx.fsf@gmail.com> (message from Gerd Möllmann on Fri, 13 Dec 2024 16:09:30 +0100)
> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Date: Fri, 13 Dec 2024 16:09:30 +0100
>
> Improvements:
>
> 1. Separators are displayed as lines over the whole menu, not
> only as "--".
>
> 2. Support for 3 types of separators: --space -> line
> of spaces, --double-line -> line of '=', others -> line of '-'
Thanks.
> +static void
> +display_tty_menu_separator (struct it *it, const char *label, int width)
> +{
> + static char sep[200];
Why 200? GNU Coding Standards frown on arbitrary limits.
How about using alloca with 'width' as its argument?
next prev parent reply other threads:[~2024-12-13 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 15:09 bug#74854: [PATCH] Improve menu separator display on ttys slightly Gerd Möllmann
2024-12-13 16:16 ` Eli Zaretskii [this message]
2024-12-13 17:24 ` Gerd Möllmann
2024-12-14 7:15 ` Eli Zaretskii
2024-12-14 7:25 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634iry2vg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=74854@debbugs.gnu.org \
--cc=gerd.moellmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.