Re: Add Tango and Adwaita icons for the toolbar

[Yuan Fu <casouri@gmail.com>]

> On May 4, 2024, at 5:22 PM, Po Lu <luangruo@yahoo.com> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
>> I don’t think it’s necessary to generate XPM and BPM versions, because
>> if you compare the new icons with the old, you’ll find that they are
>> essentially the same icon (same shape, motif, etc). That is to say, we
>> already have XPM and BPM version of the icons: the current ones.
> 
> The sizes and designs of the new icons are different from the originals,
> and I will not stand for having even the _tool-bar_ icons be inferior
> when this or that optional dependency is not available.  Moreover, XPM
> icons are better efficiency-wise on X, all the more so when the display
> is on the other end of a wide-area network connection.

I don’t understand, don’t you like the current icons better? Why are they inferior now? I certainly would like to have xpm and bpm versions for the new icons, but as I said, I’m no graphic designer and have no ability to hand-draw them; the only thing I can do is to convert them from png, which you also against. (Though, to be fair, even if I have the ability, I probably wouldn’t want to, it’s a lot of work to hand draw all these icons.)

> 
>> Also the icons are in png format, the source is svg, but I exported
>> the svg into png. Because svg isn’t rendered very well, presumably
>> because theses icons are relatively complicated? (More complicated
>> than the symbolic icons for sure.)
> 
> If the display of the SVGs is inadequate, they would better be removed
> completely.

They are the “source file” of the png icons. And I didn’t just take these svg from else where, I had to make many modifications to them. If we want to later export png files with different sizes, or tweak the icons, we need these svgs.

> 
>> As for opting-out, there isn’t a mechanism to explicitly choose what
>> version of icons to use in tool-bar.el right now. So it’ll need to be
>> added. I believe the branch mentioned in the original discussion,
>> created by Stefan K, has some mechanism for an “icon theme”. Maybe we
>> can merge that, plus the new monotone icons in that branch, but left
>> out changing the tool-bar icons?
>> 
>> It’ll be a big project to find counterparts for all the current icons,
>> plus I’m not a designer so I can’t conjure up icons by myself :-) I
>> think we could make it opt-in first, and make it default when we have
>> full coverage.
> 
> Whatever you decide, please don't merge it into master until it is
> ready.  I suggest reusing the sctatch/icons branch for the time being.

I’m not going to merge it before discussion settled.

Yuan