From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 59a895ec499: ; * .gitignore: Add lisp/eshell/esh-groups.el. Date: Sun, 28 Jul 2024 10:21:30 -0700 Message-ID: <86257a62-bad8-414d-a73f-d9b820998768@gmail.com> References: <172200213962.12077.5959128939547244584@vcs2.savannah.gnu.org> <20240726135539.EFFE2C3535E@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28003"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org, Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 28 19:22:17 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sY7b6-00078D-Np for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Jul 2024 19:22:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sY7aQ-0001IX-W0; Sun, 28 Jul 2024 13:21:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sY7aP-0001Hr-4i for emacs-devel@gnu.org; Sun, 28 Jul 2024 13:21:33 -0400 Original-Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sY7aN-0001pr-G3; Sun, 28 Jul 2024 13:21:32 -0400 Original-Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-70d1a74a43bso1605496b3a.1; Sun, 28 Jul 2024 10:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722187289; x=1722792089; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=jsdGkTRk9FYARGy2Z/T38iYVS5DmddtOCrrgE7WTTtU=; b=mHihj+8YN9HCnSR/JeIAjXNDA8koYU+rYhpqobseLWSWayuVOVWWWhI2PZVenh+B6F lV0Bj4xNTKZiXS38sGktJddrdruPFA04gKxHJUFFfSWoe0GyUYjrNfpUCROfNbiXLU7o UUMrMM4xsferLEhCy5/dhFV18MF1s9NRX5eENS/sr1mykj6SS4dJEI+J1wMy92pUuB3t x0JJoNJmcDDnW6Tesw93qaFg1qLZJSX+P0w8mBhE3Mi8EtSFdCUW6ryOVE/7x1HFHKll BhSnIm3RcEYIxEy25NG7qJIRkeB2KweAlVELcVqcdLSoqegeC2rtHK25KHqhmr5IkXIQ ZbdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722187289; x=1722792089; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jsdGkTRk9FYARGy2Z/T38iYVS5DmddtOCrrgE7WTTtU=; b=OH4jDigIgKFJ85ugQqrwm79Z27DInUXdz1D4eSgOrwC3gYtasmKpLvmmoddUodFM9Q nWDphDI2xRMdVRf2CvGLpeQ9QjrtfkMjX+KSpZsBZIivfwGfOfEWSNNvC1fiEJlN335q 2sMfedtqfn4XqmFZ096mk5i0T7gQYkaOxh5QukfIYwhCJyDVPqa806h3AaHv4jkU0EN3 hBY2CyAy9Zfyvysw1h36aGEr2Hx60OjHc5mPJwG0BK8xcoT4MWyQLH50RFmb5spGrbFI cHcDvRft2cIr+PP9zbR2NmFGS832a0Rlxm8BZf8iqwqPdinhHBh2DtAgrCqF+ekK2MVK IYbA== X-Forwarded-Encrypted: i=1; AJvYcCUSgyysjEf0GjFaWnqeSmTRPnq0IDJO6btN9faMlcKpuVYiFGNBH4/AEIHck3R/YeFwolkxm2xLBl3BTjU= X-Gm-Message-State: AOJu0Ywk8vM+iReQX5iGXEl2Rnavrr9YYw1Vi7JwqBaNUfDe3UJjfaJ+ Quh2N3mCv2t9uVu0199LuwQ47/k211Fvry6e3ZXG+P/FELgM98kT4fBYBg== X-Google-Smtp-Source: AGHT+IGAk4f+ksqxAMtefXjg1Yx0nVmLFgZaPOe7Qxc6NIDHHL1Nnq+FCU9DBctnM7usLS6FWEzimg== X-Received: by 2002:a05:6a20:6a10:b0:1c2:8d33:af69 with SMTP id adf61e73a8af0-1c4a13afd31mr4032918637.41.1722187289406; Sun, 28 Jul 2024 10:21:29 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1fed7f957acsm67205065ad.252.2024.07.28.10.21.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jul 2024 10:21:29 -0700 (PDT) Content-Language: en-US In-Reply-To: <20240726135539.EFFE2C3535E@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322172 Archived-At: On 7/26/2024 6:55 AM, Eli Zaretskii wrote: > branch: emacs-30 > commit 59a895ec4991beff9862029a712b22b47c5b70b3 > Author: Eli Zaretskii > Commit: Eli Zaretskii > > ; * .gitignore: Add lisp/eshell/esh-groups.el. > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index eb76ff330b8..9c58e2ebfac 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -130,6 +130,7 @@ lisp/cedet/semantic/wisent/python-wy.el > lisp/cedet/srecode/srt-wy.el > lisp/cedet/semantic/grammar-wy.el > lisp/eshell/esh-module-loaddefs.el > +lisp/eshell/esh-groups.el > lisp/finder-inf.el > lisp/leim/ja-dic/ > leim/small-ja-dic-option Just for context, I'd previously removed this line in 4c924a533340, since Eshell no longer generates the "esh-groups.el" file (it generates "esh-module-loaddefs.el"; this was part of a change to allow ordinary autloads in Eshell modules alongside module-specific autoloads). I don't see any issue with leaving "esh-groups.el" in the gitignore if it's more convenient for switching between older branches though. Would a comment here be useful to indicate that at some point in the future, people could remove that entry?