From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: New warnings on emacs-26 branch with gcc 8.2.0 Date: Sat, 11 Aug 2018 20:04:26 +0100 Message-ID: <861sb4iv2d.fsf@gmail.com> References: <86a7q0ai2z.fsf@gmail.com> <6d36dc4c-1e14-b6c8-e2f0-911d08f759e1@cs.ucla.edu> <83in4os01j.fsf@gnu.org> <16f2754a-b40e-4bc4-f95a-9bada460d5a4@cs.ucla.edu> <83bma9mh3z.fsf@gnu.org> <86eff52njj.fsf@gmail.com> <83wosxkwfz.fsf@gnu.org> <864lg1rlp0.fsf@gmail.com> <83mutslt8f.fsf@gnu.org> <86in4gixg3.fsf@gmail.com> <83d0uolpxt.fsf@gnu.org> <86600giwct.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534014197 15074 195.159.176.226 (11 Aug 2018 19:03:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 11 Aug 2018 19:03:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 11 21:03:13 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1foZAP-0003pt-Il for ged-emacs-devel@m.gmane.org; Sat, 11 Aug 2018 21:03:13 +0200 Original-Received: from localhost ([::1]:32906 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foZCW-0005KX-5W for ged-emacs-devel@m.gmane.org; Sat, 11 Aug 2018 15:05:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foZBq-0005KR-Eg for emacs-devel@gnu.org; Sat, 11 Aug 2018 15:04:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foZBm-0001Ud-VP for emacs-devel@gnu.org; Sat, 11 Aug 2018 15:04:42 -0400 Original-Received: from [195.159.176.226] (port=36694 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1foZBm-0001U6-Nj for emacs-devel@gnu.org; Sat, 11 Aug 2018 15:04:38 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1foZ9c-0002zD-Aw for emacs-devel@gnu.org; Sat, 11 Aug 2018 21:02:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 53 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:cg1PxXvCuYXAueTGrRiYtq+JyNk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228424 Archived-At: On Sat 11 Aug 2018, Andy Moreton wrote: > On Sat 11 Aug 2018, Eli Zaretskii wrote: > >>> From: Andy Moreton >>> Date: Sat, 11 Aug 2018 19:13:00 +0100 >>> >>> > Does it help to take the GetProcAddress call in parentheses, like >>> > this: >>> > >>> > s_pfn_Get_Module_HandleExA = >>> > (GetModuleHandleExA_Proc) (GetProcAddress (hm_kernel32, >>> > "GetModuleHandleExA")); >>> >>> Doesn't help - gcc still warns. >>> >>> > If this doesn't help, what about removing the cast entirely? >>> >>> Also still warns. This does work: >>> >>> s_pfn_Get_Module_HandleExA = >>> (GetModuleHandleExA_Proc) (void (*)(void)) >>> GetProcAddress (hm_kernel32, "GetModuleHandleExA"); >>> >>> This is sliughtly less ugly and also pacifies the warning: >>> >>> #define FN_PTR_CAST(fnptrtype, fnptr) \ >>> ((fnptrtype) (void (*)(void)) (fnptr)) >>> >>> s_pfn_Get_Module_HandleExA = >>> FN_PTR_CAST(GetModuleHandleExA_Proc, >>> GetProcAddress (hm_kernel32, "GetModuleHandleExA")); >> >> I'd rather disable the warning around the code which uses these casts. >> Or maybe we should introduce our ownj get_proc_address, which returns >> a (void (*)(void)) pointer. But that's not for emacs-26, sorry. For the record, with get_proc_address like this: typedef void (*VOIDFNPTR)(void); VOIDFNPTR get_proc_address (HINSTANCE handle, LPCSTR fname) { return (VOIDFNPTR) GetProcAddress (handle, fname); } Then the following does not trigger the warning: s_pfn_Get_Module_HandleExA = (GetModuleHandleExA_Proc) get_proc_address (hm_kernel32, "GetModuleHandleExA");