From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Making 'eq' == 'eql' in bignum branch Date: Mon, 20 Aug 2018 09:49:50 +0100 Message-ID: <861sato21d.fsf@gmail.com> References: <29f933ac-a6bf-8742-66a7-0a9d6d3e5a88@disroot.org> <49d8ba62-c9a5-9203-d882-8e900b441ff3@cs.ucla.edu> <8e0320d9-e0d0-2b57-57cc-2df4399f133c@cs.ucla.edu> <87lgaio7xd.fsf@tromey.com> <877em1cb0i.fsf@tromey.com> <765767b2-d2e5-a9a6-f724-d58ecf4847bb@cs.ucla.edu> <76081b5d-8c10-0a37-2c97-d4864c0faa80@cs.ucla.edu> <09153aed-361d-4f82-d9ac-b502314769ae@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534754894 11998 195.159.176.226 (20 Aug 2018 08:48:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2018 08:48:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 10:48:10 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frfr7-0002xo-Mc for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 10:48:09 +0200 Original-Received: from localhost ([::1]:45573 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frftC-0003XS-Fy for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 04:50:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frft0-0003VM-QO for emacs-devel@gnu.org; Mon, 20 Aug 2018 04:50:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frfsx-0006pm-Jl for emacs-devel@gnu.org; Mon, 20 Aug 2018 04:50:06 -0400 Original-Received: from [195.159.176.226] (port=34632 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frfsx-0006pZ-Ch for emacs-devel@gnu.org; Mon, 20 Aug 2018 04:50:03 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1frfql-0002V3-So for emacs-devel@gnu.org; Mon, 20 Aug 2018 10:47:47 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 21 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:4B7/JDg5r3q7/aQ2yPB8+CfpdlE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228716 Archived-At: On Mon 20 Aug 2018, Paul Eggert wrote: > Pip Cet wrote: >> I think references to most-positive-fixnum (and implicit ones, like >> using Frandom without an argument) should be eliminated. Fixnum range >> is now an implementation detail. There will always be a performance diffrence between fixnum and bignum values, and it may be useful for performance tuning to have a simple way to discover where that boundary lies. > I tend to agree. Also, we should remove the fixnump and bignump functions; > these functions certainly don't need to be in C code and I don't see why they > even need to be present at all. We shouldn't be giving users the impression > that the distinction between fixnums and bignums is important. These are used in the tests to ensure that implementation is correct, and that values in fixnum range are always represented as fixnums, not bignums. How do you propose to test that without these predicates ? AndyM