From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: autoload cl-defstruct constructor? Date: Mon, 09 Sep 2019 12:12:56 -0700 Message-ID: <861rwp8err.fsf@stephe-leake.org> References: <86k1anriz5.fsf@stephe-leake.org> <86ef0u8geu.fsf@stephe-leake.org> <86a7bh83l2.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="51331"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 09 21:13:13 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i7P66-000DBo-Mm for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 21:13:10 +0200 Original-Received: from localhost ([::1]:60144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7P65-0002fw-Lq for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 15:13:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43370) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7P5y-0002fo-Qr for emacs-devel@gnu.org; Mon, 09 Sep 2019 15:13:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7P5x-0007y4-8G for emacs-devel@gnu.org; Mon, 09 Sep 2019 15:13:02 -0400 Original-Received: from gateway36.websitewelcome.com ([192.185.200.11]:41205) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7P5x-0007xL-0T for emacs-devel@gnu.org; Mon, 09 Sep 2019 15:13:01 -0400 Original-Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 10E9A401C6F80 for ; Mon, 9 Sep 2019 13:39:35 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id 7P5uimVXH3Qi07P5viPQUd; Mon, 09 Sep 2019 14:12:59 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BR4p18BlAmZc9fRrHfoiIgyIyt9Wp/Pfn2moEb3utuQ=; b=O6Thc5pLm5YFFqtXaJsR3iNEn uQ4WpLDSCSgWhPdFf+D8JXaa7GEEjWb+JIdS1odtpiAYVJvnYArZS/XOebZaAxtD9FvOMhuao2xAz 9EFeclNcfcY3Yv4xrDIyQbNr0D+A5XOxwz5+MepQsxF+qn7bTAuP+UxNfA7MqGnCYxki0wpdtfQPg CIPqLNgo8FfXwTNFa5jARy9/tf+3kTmX9l+v5V/nXFikJOIfN6miLBbCJJq+/y3Mo4PoKBAKnUMa/ wxhi70Cfa7cPH1oWkd7AEoKsgayVaN/gLclsBXngxfSaL2L6JxbxfZnJvXbPtn1ARjwGUkc5Dwg+4 Jv1/kwX+A==; Original-Received: from [76.77.182.20] (port=51679 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i7P5u-004GKq-M0 for emacs-devel@gnu.org; Mon, 09 Sep 2019 13:12:58 -0600 In-Reply-To: (Stefan Monnier's message of "Sat, 07 Sep 2019 10:29:12 -0400") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1i7P5u-004GKq-M0 X-Source-Sender: (Takver4) [76.77.182.20]:51679 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 1 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 192.185.200.11 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239962 Archived-At: Applying both patches works nicely. Should I commit this to master? Now I have to figure out the minimum workaround for emacs 25, 26 compatibility. Stefan Monnier writes: >> Hmm. To build autoloads.el for ada-mode in my development tree, I run: >> >> emacs -Q -batch --eval "(progn (require 'autoload)(require 'cl-lib)(setq >> generated-autoload-file (expand-file-name >> \"../autoloads.el\"))(update-directory-autoloads \"../\"))" >> >> I just added the (require 'cl-lib), but I still get the same result for >> a cl-defstruct: > > Hmm... indeed it looks like you also need the patch below. > >> We'll need to ensure package.el does the same when it generates >> autoloads. Or is that done on the elpa server? > > Indeed. The autoloads are built when *installing* a package, so they're > built by the user's Emacs, which may be "old". > > > Stefan > > > diff --git a/lisp/emacs-lisp/autoload.el b/lisp/emacs-lisp/autoload.el > index 541b22e3ee..8ec5150cca 100644 > --- a/lisp/emacs-lisp/autoload.el > +++ b/lisp/emacs-lisp/autoload.el > @@ -165,7 +165,7 @@ make-autoload > define-globalized-minor-mode defun defmacro > easy-mmode-define-minor-mode define-minor-mode > define-inline cl-defun cl-defmacro cl-defgeneric > - pcase-defmacro)) > + pcase-defmacro cl-defstruct)) > (macrop car) > (setq expand (let ((load-file-name file)) (macroexpand form))) > (memq (car expand) '(progn prog1 defalias))) > > > -- -- Stephe