From: Juri Linkov <juri@linkov.net>
To: "João Távora" <joaotavora@gmail.com>
Cc: 61943@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Sean Whitton <spwhitton@spwhitton.name>
Subject: bug#61943: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too
Date: Sat, 04 Mar 2023 20:52:08 +0200 [thread overview]
Message-ID: <861qm4fixz.fsf@mail.linkov.net> (raw)
In-Reply-To: <CALDnm52DGtgvf+ft6RLJ9NOodKo=NZLPzQMqGvn99+eCf+PwEg@mail.gmail.com> ("João Távora"'s message of "Sat, 4 Mar 2023 11:30:48 +0000")
> All in all, I'm not sure we should be shipping this half-baked
> enhancement for emacs-29, at least not in this phase. I propose
> we revert it in emacs-29.
>
> I propose we revert it from there, keep the changes in master,
> and focus on making it more consistent there.
The patch that I created fixed a bug where in-buffer completion
erased the whole buffer so it needs to stay in emacs-29.
Also for your convenience I pushed your patch that adds support
for in-buffer completion to fido-mode in the hope that the patch
is already in the finished state. However, if you think that
fido-vertical mode and/or icomplete-vertical-mode needs more work
to support in-buffer completions, please decide whether to revert it
or to write an additional patch for these modes in emacs-29.
next prev parent reply other threads:[~2023-03-04 18:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 18:18 bug#61943: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too Sean Whitton
2023-03-03 20:26 ` João Távora
2023-03-04 2:13 ` Sean Whitton
2023-03-04 2:35 ` Sean Whitton
2023-03-04 11:30 ` João Távora
2023-03-04 18:52 ` Juri Linkov [this message]
2023-03-04 19:04 ` João Távora
2023-03-04 19:14 ` Juri Linkov
2023-03-04 20:44 ` Sean Whitton
2023-03-21 22:06 ` Sean Whitton
2023-03-21 23:40 ` João Távora
2023-03-22 17:25 ` Sean Whitton
2023-03-22 18:43 ` João Távora
2023-03-23 19:13 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861qm4fixz.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=61943@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.