From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Updating *Completions* as you type Date: Tue, 21 Nov 2023 19:09:02 +0200 Organization: LINKOV.NET Message-ID: <861qcjw3ch.fsf@mail.linkov.net> References: <87bkd3z9bi.fsf@catern.com> <86cyxjyr1y.fsf@mail.linkov.net> <86r0lxm7um.fsf@mail.linkov.net> <87sf6dx954.fsf@catern.com> <87ttqpwea9.fsf@catern.com> <86wmvlw178.fsf@mail.linkov.net> <87bkcwx3ft.fsf@catern.com> <86y1g076vh.fsf@mail.linkov.net> <87sf68unh1.fsf@catern.com> <86zg0fu99i.fsf@mail.linkov.net> <875y33v73h.fsf@catern.com> <87y1fztke8.fsf@catern.com> <86r0lrw17x.fsf@mail.linkov.net> <87il5xlf9b.fsf@catern.com> <86y1esuajx.fsf@mail.linkov.net> <86v89ws5t3.fsf@mail.linkov.net> <86v89vzf1o.fsf@mail.linkov.net> <87pm03jn3w.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14308"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: sbaugh@catern.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 21 18:13:56 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r5UJw-0003az-1O for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Nov 2023 18:13:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5UJ4-0002A6-Tv; Tue, 21 Nov 2023 12:13:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5UJ3-00025t-Df for emacs-devel@gnu.org; Tue, 21 Nov 2023 12:13:01 -0500 Original-Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5UJ1-0003Wq-LO for emacs-devel@gnu.org; Tue, 21 Nov 2023 12:13:01 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 056AB6000D; Tue, 21 Nov 2023 17:12:56 +0000 (UTC) In-Reply-To: <87pm03jn3w.fsf@catern.com> (sbaugh@catern.com's message of "Tue, 21 Nov 2023 12:40:35 +0000") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::223; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313118 Archived-At: >>> (or >>> (alist-get 'display-sort-function (alist-get category completion-category-overrides)) >>> (alist-get 'display-sort-function metadata) >>> (alist-get 'display-sort-function (alist-get category completion-category-defaults)) >>> completions-sort) >> >> 1. display-buffer-overriding-action >> 2. display-buffer-alist >> 3. function call arguments that correspond to completion metadata >> 4. display-buffer-base-action >> 5. display-buffer-fallback-action > > A few points in favor of > > (alist-get 'display-sort-function metadata) > (alist-get 'display-sort-function (alist-get category completion-category-overrides)) > > instead: > > - Again, the user is still able to configure the display-sort-function > by configuring the individual completion table. Does this mean that every individual completion table should have a separate user option? > That's not true with display-buffer. The only configuration > mechanism is display-buffer-alist. Actually several user options already exist for display-buffer such as display-comint-buffer-action and display-tex-shell-buffer-action. They cover a whole category of display-buffer calls that display all types of comint buffers, etc. So these options correspond to completion categories, not to individual completion tables. > - Given that the user can still configure the display-sort-function, I > don't see any use case where the user should override it. (A buggy > completion table that returns the wrong display-sort-function? But > that should just be fixed.) I don't understand how the user can configure the display-sort-function, please elaborate. > - display-buffer-alist is driven purely by buffer-match-p conditions, so > there's a linear sequence of overriding. The display-sort-function > has two levels: the completion table and the completion category. > Since the table is more specific than the category, it should override > the category. Agreed. But this means only one thing that a user option for an individual completion table should take precedence over completion-category-overrides. > - As a minor point, I, and many other Emacs users IME, find the > display-buffer configuration to be complex and hard to use, so I don't > think we should try to emulate it too much. What is an alternative? A myriad of individual options? > - The "overrides" in "completion-category-overrides" is just a name. It > doesn't mean that we have to make it override everything else. Why not to do what the name suggests? > Alternatively, could we just add support for configuring the individual > table now, and add category-based configuration later? We don't need to > add everything all at once, and that will give us valuable user > feedback. I see no need to add individual options as all. Every completion table that significantly differs from other tables so that it needs a separate display-sort-function, could provide a separate category. For example, there is a category 'buffer'. If 'switch-to-buffer' needs another display-sort-function it could provide a category 'buffer-for-switching'.