From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70329: 29.3; etags-regen-mode fails in projects that have spaces in their root path elements Date: Thu, 11 Apr 2024 10:29:43 +0300 Message-ID: <861q7cuzko.fsf@gnu.org> References: <7yv84p3tee.fsf@icloud.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33285"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70329@debbugs.gnu.org To: Magiel Bruntink Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 11 09:31:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruotz-0008Og-90 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Apr 2024 09:31:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruotc-00061z-9b; Thu, 11 Apr 2024 03:30:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruota-00061m-6e for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2024 03:30:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ruotZ-0005vW-TV for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2024 03:30:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ruoti-0003pr-Qy for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2024 03:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Apr 2024 07:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70329 X-GNU-PR-Package: emacs Original-Received: via spool by 70329-submit@debbugs.gnu.org id=B70329.171282060714275 (code B ref 70329); Thu, 11 Apr 2024 07:31:02 +0000 Original-Received: (at 70329) by debbugs.gnu.org; 11 Apr 2024 07:30:07 +0000 Original-Received: from localhost ([127.0.0.1]:54800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruosn-0003hw-Dx for submit@debbugs.gnu.org; Thu, 11 Apr 2024 03:30:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruosi-0003fl-E2 for 70329@debbugs.gnu.org; Thu, 11 Apr 2024 03:30:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruosT-0005aY-VN; Thu, 11 Apr 2024 03:29:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=E3XF1BioMi0PLvIM63DqOkWE1W2VyGvsA00ay9waTLI=; b=WJ7GLWVJJIzA Ll9gTblXnatqIkPcaAEPiRtlJe0ir1kqnz6iXAI603N6z0ekSEJAkbxYe6Djw40SMmEbJwFVeMtEb LzQj3FgG0OMvSatOQoPD7NHFrPpIsjJH3SlvulVXEaAiGrw5q5PpJVxnyhBEwdAssQN/piJfKTJvY BGk5y5iIqR8LpTcWwezAc8ZoaeC581eBWwn7if8paTCJwT1zykI8GnjLVNddMjBcYov9w6c7n3fbV wOdu4DRgL3reZlRqqPARGYyBqsNAfJdlQtbwhx7oqp27c+iUOK27B+jeANzMy+eX4/x9MjPy/VERs WHTzfBJrkNfE4i0yqjfuHw==; In-Reply-To: <7yv84p3tee.fsf@icloud.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283082 Archived-At: > Date: Wed, 10 Apr 2024 21:32:57 +0200 > From: Magiel Bruntink via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I wanted to try to the new etags-regen-mode and loaded its lisp manually. > > There is an issue with how the new mode deals with paths containing spaces, > however. > > Running the etags--xref-backend through eg. xref-find-definitions > within a file in a project that has spaces in its path elements, > eg. "c:/temp/test project/test.c" will cause an error. > > Messages seen are: > Generating new tags table... > (Shell command failed with code 1 and some error output) > visit-tags-table-buffer: File c:/temp/test project/TAGS does not exist > > Error message in the etags-regen-tags-errors* buffer: > c:/temp/test: Permission denied Stab in the dark: does the patch below fix the problem? If not, please repeat your recipe with debug-on-error non-nil, and post the backtrace here. diff --git a/lisp/progmodes/etags-regen.el b/lisp/progmodes/etags-regen.el index 6cd78d3..02d666c 100644 --- a/lisp/progmodes/etags-regen.el +++ b/lisp/progmodes/etags-regen.el @@ -279,7 +279,7 @@ etags-regen--tags-generate " ") ;; ctags's etags requires '-L' for stdin input. (if ctags-p "-L" "") - tags-file))) + (shell-quote-argument tags-file)))) (with-temp-buffer (mapc (lambda (f) (insert f "\n"))