From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Add Tango and Adwaita icons for the toolbar Date: Fri, 10 May 2024 10:06:24 +0300 Message-ID: <861q6a5eof.fsf@gnu.org> References: <15F31342-2F2E-4F1E-9FE2-D8F1A62BCC5A@gmail.com> <2F9EE9AF-EEE6-4296-9FDA-B9F8C1B1EE6A@gmail.com> <16A36319-611E-4D49-B374-BE2AE1928D5D@gmail.com> <865xvm1kz0.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26934"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, emacs-devel@gnu.org, luangruo@yahoo.com To: "Elijah G." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 10 09:07:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s5KLb-0006ir-LG for ged-emacs-devel@m.gmane-mx.org; Fri, 10 May 2024 09:07:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5KL0-000752-3p; Fri, 10 May 2024 03:06:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5KKw-00073K-AQ for emacs-devel@gnu.org; Fri, 10 May 2024 03:06:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5KKt-0000Da-Et; Fri, 10 May 2024 03:06:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=JMzu9deLM//uNATzMsYG51KrCn2EifuCUF4ZigTiZOs=; b=V7IyftIyUKvqN+J619t0 2ntwGOaBS7g5GT3K9EKv47Jf00ReMViihSU85BOWb+zjkutA7S53SCRqaEpFg2ijj6GgC9jLo18fN EmIaCUNR2Kuo7g4Kg9dkHqj1tAGkjjKZttpQrKii8MLrmCo9s1HdqmU8CayXRKF0F27SShfE5JVNU 8mjE5+WCihPsBLitAbh5vZkl1wZoGuBikmiErz7HIR/l5bAUC3LCbl+2BKa4WHpUvJPMhvhvkSP7l AmA3sWbZKdKLiHxjX6i5kTRbVBHsFRBdy+9yE16V7hUSfB7pyyisHY6LwwwtEuY7+15Ft5RKyOgzS ha4u+cPcTT7N1w==; In-Reply-To: <865xvm1kz0.fsf@gmail.com> (eg642616@gmail.com) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319114 Archived-At: > From: "Elijah G." > Cc: , Po Lu > Date: Thu, 09 May 2024 20:04:03 -0600 > > > We also need some way to opt-out of the new icons. I’ll try to figure > > it out. > > I've made a litle patch that can help in that (note: I've not tested it > yet and i don't think i can test it :( ). > The new icons are enabled by default but it can be switched to the > current ones (also i think that defcustom should specify that it must > be set in early-init.el because AFAIK tool-bar can not refresh the icons). Is "tool-bar theme" really a good idea for this? AFAIK, we didn't decide to introduce "tool-bar themes", and so doing this as part of adding new icons is not TRT, it should be a separate and well-documented decision, since the results are visible to users. > + (xpm-spec (list :type 'xpm :file > + (concat icon > + (if (eq tool-bar-icon-theme 'tango) "tango/") > + ".xpm"))) Shouldn't you _prepend_ "tango/" to the icon's file name? In any case, I find this way of implementing a tool-bar theme inelegant: we'd need a test for each supported theme, which doesn't scale. This issue needs more thought and discussions. Let's not mix the new icons with this "theme" issue.