From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: gabriele@medialab.sissa.it, 71429@debbugs.gnu.org,
stefankangas@gmail.com
Subject: bug#71429: Inconsistent y-or-n-p prompt behavior in Emacs Lisp
Date: Sat, 08 Jun 2024 17:58:17 +0300 [thread overview]
Message-ID: <861q57cwhi.fsf@gnu.org> (raw)
In-Reply-To: <87h6e3lemo.fsf@gmx.net> (message from Stephen Berman on Sat, 08 Jun 2024 15:59:11 +0200)
> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: Gabriele Nicolardi <gabriele@medialab.sissa.it>, Stefan Kangas
> <stefankangas@gmail.com>, 71429@debbugs.gnu.org
> Date: Sat, 08 Jun 2024 15:59:11 +0200
>
> >> I actually don't understand why we use \\`y' and \\`n' in y-or-n-p.
> >> Why those backslashes, and not just `y' and `n'? That's your change
> >> in commit a36ecc408a. If I remove the backslashes, the results are
> >> identical whether or not search-spaces-regexp is let-bound.
>
> Without the backslashes the cond-clause in substitute-command-keys
> handling sequences starting with "\" is skipped, so "y" and "n" do not
> get the help-key-binding face property.
This should be explained in a comment in y-or-n-p.
> Stepping through substitute-command-keys in Edebug, I see that when the
> regexp ends in '?' or '*' the sexp (key-valid-p k) in
> substitute-command-keys returns nil for k set to "y" and then to "n", so
> these strings do not get the help-key-binding face property and "(\\`y'
> or \\`n') " is returned to y-or-n-p unaltered. When the regexp does not
> end in '?' or '*', (key-valid-p k) returns t for "y" and "n" and these
> strings get propertized.
>
> Stepping through key-valid-p, I see that when the regexp ends in '?' or
> '*' the sexp (split-string keys " ") returns (#1="" "y" #1#) for keys
> set to "y", and key-valid-p loops over this lists, and the first element
> "" is an invalid key. When the regexp does not end in '?' or '*' the
> split-string sexp in key-valid-p returns ("y"), and "y" is valid.
Thanks. To me, this means that key-valid-p should bind
search-spaces-regexp to nil, because otherwise the value will subvert
its contract. Do you agree?
I added Stefan Monnier to the discussion in the hope he would have
comments to this.
> And stepping through split-string, I see that when the regexp ends in
> '?' or '*', the invocation of string-match in the while-loop with args
> REGEXP set to " ", STRING set to "y" and START set to 0 returns 0, which
> results in "" being pushed onto the list both before and after "y",
> hence returning (#1="" "y" #1#). When the regexp does not end in '?' or
> '*', the string-match invocation returns nil and only "y" is pushed onto
> the list.
We should ad to split-string's doc string the fact that
search-spaces-regexp affects its results when SEPARATORS includes
whitespace.
next prev parent reply other threads:[~2024-06-08 14:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 7:03 bug#71429: Inconsistent y-or-n-p prompt behavior in Emacs Lisp Gabriele Nicolardi
2024-06-08 8:24 ` Eli Zaretskii
2024-06-08 9:20 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 13:59 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 14:58 ` Eli Zaretskii [this message]
2024-06-08 15:30 ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 15:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 16:36 ` Eli Zaretskii
2024-06-08 17:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 18:08 ` Eli Zaretskii
2024-06-09 11:02 ` Stefan Kangas
2024-06-08 15:47 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 16:44 ` Eli Zaretskii
2024-06-09 11:01 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861q57cwhi.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71429@debbugs.gnu.org \
--cc=gabriele@medialab.sissa.it \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.