From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode Date: Sun, 23 Jun 2024 17:56:02 +0300 Message-ID: <861q4nemil.fsf@gnu.org> References: <868r0ajh5j.fsf@gnu.org> <86bk55iw54.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29382"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ankit@argp.in, 70939@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 23 16:57:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLOed-0007QZ-6D for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jun 2024 16:57:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLOeO-00052G-3E; Sun, 23 Jun 2024 10:57:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLOeL-00051s-VT for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 10:57:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLOeL-0006ee-O3 for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 10:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLOeL-00075m-WE for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 10:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2024 14:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70939 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70939-submit@debbugs.gnu.org id=B70939.171915457727160 (code B ref 70939); Sun, 23 Jun 2024 14:57:01 +0000 Original-Received: (at 70939) by debbugs.gnu.org; 23 Jun 2024 14:56:17 +0000 Original-Received: from localhost ([127.0.0.1]:35945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLOdd-00073z-F0 for submit@debbugs.gnu.org; Sun, 23 Jun 2024 10:56:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLOdb-00073e-FT for 70939@debbugs.gnu.org; Sun, 23 Jun 2024 10:56:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLOdT-0006ZO-B0; Sun, 23 Jun 2024 10:56:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bHH470X49bTpdNxtRgXB+7vUQO6aPtmAcJiOhu57M6s=; b=SsyWE9mp3yUi 4tXghm+RNuwdQ7txLodB8Psad3UI8ifMTvaTMSicZyRCAfQ1Pw2m51+wTT2A6AzPwyaOEuX0w/3WA ikf1iiz6P3m5qHMdlV7EAHxnOMWqL7D9y7tTLZB7Oy12dvnSDeEA0Mo2d91qtzVfEBK1w9R0y8y1Y uE2MC87GJxtFj1ZYob2+CmGhflX7twFOpwxOOqHBrMgV1Z1snSRl4euE5Ev+Vg2dIbDkD7VjNjPjB Q9SuFHsOYy4dh03NpoQB80bJls/+SWFdXm/qRPPX6yD59yn5NUWa1UuOTjyPo/fF7MvsQr5IvcVmz CbejQrwZ6Hc5wmDa8PMRow==; In-Reply-To: (message from Randy Taylor on Fri, 21 Jun 2024 02:40:12 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287793 Archived-At: > Date: Fri, 21 Jun 2024 02:40:12 +0000 > From: Randy Taylor > Cc: Eli Zaretskii , 70939@debbugs.gnu.org > > For the commit message, I'm not sure we need that paragraph especially when it's already described in the news. Eli what do you think? Yes, the commit log doesn't need to say again what is already in NEWS, it can be shorter. > I'm also wondering if we should include "current" in the go-ts-mode-test-file and go-ts-mode-test-package function names. Maybe someone would expect that they would get prompted to select a file or package to test? Maybe I'm overthinking that :). Eli what do you think? I'd use "this" instead of "current".