From: Eli Zaretskii <eliz@gnu.org>
To: Visuwesh <visuweshm@gmail.com>
Cc: 72405@debbugs.gnu.org, monnier@iro.umontreal.ca, drew.adams@oracle.com
Subject: bug#72405: 29.4; Doc string of `org-indent-mode'
Date: Wed, 14 Aug 2024 10:55:20 +0300 [thread overview]
Message-ID: <861q2ra68n.fsf@gnu.org> (raw)
In-Reply-To: <87y14zy36y.fsf@gmail.com> (message from Visuwesh on Wed, 14 Aug 2024 12:57:17 +0530)
> From: Visuwesh <visuweshm@gmail.com>
> Cc: monnier@iro.umontreal.ca, 72405@debbugs.gnu.org, drew.adams@oracle.com
> Date: Wed, 14 Aug 2024 12:57:17 +0530
>
> >> Is the attached patch fine?
> >
> > Yes, but please use 'if' rather than 'when'.
>
> Sorry, but I'm confused. I used 'when' because
>
> (concat nil "xxx") ;; => "xxx"
Yes, of course. But 'if' also returns nil if its condition is false:
(if (symbolp 1) "symbol")
=> nil
So you can still use the original code, which uses the above behavior
of 'concat', after replacing 'when' with 'if' in your original code.
The reason I asked to use 'if' is that there's no reason to use 'when'
here, as the BODY of 'when' will only ever be a single string.
next prev parent reply other threads:[~2024-08-14 7:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 20:23 bug#72405: 29.4; Doc string of `org-indent-mode' Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-01 5:03 ` Eli Zaretskii
2024-08-01 5:40 ` Visuwesh
2024-08-01 5:59 ` Visuwesh
2024-08-01 6:18 ` Eli Zaretskii
2024-08-14 0:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-14 2:39 ` Visuwesh
2024-08-14 6:12 ` Eli Zaretskii
2024-08-14 6:38 ` Visuwesh
2024-08-14 6:48 ` Eli Zaretskii
2024-08-14 7:27 ` Visuwesh
2024-08-14 7:55 ` Eli Zaretskii [this message]
2024-08-14 8:04 ` Visuwesh
2024-08-15 7:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861q2ra68n.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72405@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=monnier@iro.umontreal.ca \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.